From: Al Viro <viro@zeniv.linux.org.uk>
To: Congjie Zhou <zcjie0802@qq.com>
Cc: linux-fsdevel@vger.kernel.org, brauner@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs: modify the annotation of vfs_mkdir() in fs/namei.c
Date: Sat, 15 Jun 2024 04:00:56 +0100 [thread overview]
Message-ID: <20240615030056.GO1629371@ZenIV> (raw)
In-Reply-To: <tencent_3A7366F414667EE52C073850077331ADC709@qq.com>
On Sat, Jun 15, 2024 at 09:59:13AM +0800, Congjie Zhou wrote:
> modify the annotation of @dir and @dentry
> * vfs_mkdir - create directory
> * @idmap: idmap of the mount the inode was found from
> - * @dir: inode of @dentry
> - * @dentry: pointer to dentry of the base directory
> + * @dir: inode of parent dentry of @dentry
> + * @dentry: pointer to dentry of the new directory
Ugh... How about 'inode of the parent directory' and 'dentry
of the child to be' instead?
next prev parent reply other threads:[~2024-06-15 3:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-15 1:59 [PATCH] fs: modify the annotation of vfs_mkdir() in fs/namei.c Congjie Zhou
2024-06-15 3:00 ` Al Viro [this message]
2024-06-15 4:38 ` [PATCH v2] " Congjie Zhou
2024-06-15 6:29 ` Christoph Hellwig
2024-06-15 6:49 ` zcjie0802
2024-06-15 6:55 ` Al Viro
2024-06-15 7:31 ` Christoph Hellwig
2024-06-15 7:59 ` Al Viro
2024-06-15 10:34 ` [PATCH v3] fs: modify the comments " Congjie Zhou
2024-07-18 16:25 ` [PATCH v4] vfs: correct the comments of vfs_*() helpers Congjie Zhou
2024-07-19 12:05 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240615030056.GO1629371@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=brauner@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zcjie0802@qq.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).