From: Christian Brauner <brauner@kernel.org>
To: Jan Kara <jack@suse.cz>
Cc: Christian Brauner <brauner@kernel.org>,
linux-fsdevel@vger.kernel.org,
Amir Goldstein <amir73il@gmail.com>,
James Clark <james.clark@arm.com>,
linux-nfs@vger.kernel.org, NeilBrown <neilb@suse.de>,
Al Viro <viro@ZenIV.linux.org.uk>,
ltp@lists.linux.it
Subject: Re: [PATCH 1/2] fsnotify: Do not generate events for O_PATH file descriptors
Date: Tue, 18 Jun 2024 16:28:01 +0200 [thread overview]
Message-ID: <20240618-modular-galaabend-c0dba5521bc4@brauner> (raw)
In-Reply-To: <20240617162303.1596-1-jack@suse.cz>
On Mon, 17 Jun 2024 18:23:00 +0200, Jan Kara wrote:
> Currently we will not generate FS_OPEN events for O_PATH file
> descriptors but we will generate FS_CLOSE events for them. This is
> asymmetry is confusing. Arguably no fsnotify events should be generated
> for O_PATH file descriptors as they cannot be used to access or modify
> file content, they are just convenient handles to file objects like
> paths. So fix the asymmetry by stopping to generate FS_CLOSE for O_PATH
> file descriptors.
>
> [...]
I added a Cc stable to the first patch because this seems like a bugfix
per the mail discussion.
---
Applied to the vfs.fixes branch of the vfs/vfs.git tree.
Patches in the vfs.fixes branch should appear in linux-next soon.
Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.
It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.
Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.fixes
[1/2] fsnotify: Do not generate events for O_PATH file descriptors
https://git.kernel.org/vfs/vfs/c/702eb71fd650
[2/2] vfs: generate FS_CREATE before FS_OPEN when ->atomic_open used.
https://git.kernel.org/vfs/vfs/c/7d1cf5e624ef
next prev parent reply other threads:[~2024-06-18 14:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-17 16:22 [PATCH 0/2 v3] fsnotify: Generate FS_CREATE event before FS_OPEN Jan Kara
2024-06-17 16:23 ` [PATCH 1/2] fsnotify: Do not generate events for O_PATH file descriptors Jan Kara
2024-06-17 17:10 ` Amir Goldstein
2024-06-18 14:28 ` Christian Brauner [this message]
2024-06-19 15:24 ` Jan Kara
2024-06-17 16:23 ` [PATCH 2/2] vfs: generate FS_CREATE before FS_OPEN when ->atomic_open used Jan Kara
2024-06-17 17:12 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240618-modular-galaabend-c0dba5521bc4@brauner \
--to=brauner@kernel.org \
--cc=amir73il@gmail.com \
--cc=jack@suse.cz \
--cc=james.clark@arm.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=ltp@lists.linux.it \
--cc=neilb@suse.de \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).