From: Christian Brauner <brauner@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Mateusz Guzik <mjguzik@gmail.com>,
viro@zeniv.linux.org.uk, jack@suse.cz,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/2] lockref: speculatively spin waiting for the lock to be released
Date: Tue, 18 Jun 2024 14:11:44 +0200 [thread overview]
Message-ID: <20240618-spotten-scheren-0c87d248419f@brauner> (raw)
In-Reply-To: <CAHk-=whtoqTSCcAvV-X-KPqoDWxS4vxmWpuKLB+Vv8=FtUd5vA@mail.gmail.com>
On Thu, Jun 13, 2024 at 12:33:59PM GMT, Linus Torvalds wrote:
> On Thu, 13 Jun 2024 at 11:56, Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
> >
> > I didn't *think* anything in the dentry struct should care about
> > debugging, but clearly that sequence number thing did.
>
> Looking at the 32-bit build, it looks like out current 'struct dentry'
> is 136 bytes in size, not 128.
>
> Looks like DNAME_INLINE_LEN should be reduced to 36 on 32-bit.
>
> And moving d_lockref to after d_fsdata works there too.
>
> Not that anybody really cares, but let's make sure it's actually
> properly done when this is changed. Christian?
So I verified that indeed on i386 with CONFIG_SMP we need 36 to get to
128 bytes and yes, moving d_lockref after d_fsdata works. So I've put
that patch on top. (Sorry, took a bit. I'm back tomorrow.)
next prev parent reply other threads:[~2024-06-18 12:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-13 0:12 [PATCH 0/2] stop lockref from degrading to locked-only ops Mateusz Guzik
2024-06-13 0:12 ` [PATCH 1/2] lockref: speculatively spin waiting for the lock to be released Mateusz Guzik
2024-06-13 1:23 ` Linus Torvalds
2024-06-13 1:49 ` Linus Torvalds
2024-06-13 6:09 ` Mateusz Guzik
2024-06-13 13:46 ` Christian Brauner
2024-06-13 13:50 ` Mateusz Guzik
2024-06-13 17:00 ` Linus Torvalds
2024-06-13 18:13 ` Mateusz Guzik
2024-06-13 18:41 ` Mateusz Guzik
2024-06-13 18:43 ` Linus Torvalds
2024-06-13 18:47 ` Mateusz Guzik
2024-06-13 18:56 ` Linus Torvalds
2024-06-13 19:02 ` Mateusz Guzik
2024-06-13 19:33 ` Linus Torvalds
2024-06-18 12:11 ` Christian Brauner [this message]
2024-06-13 18:55 ` Al Viro
2024-06-13 16:50 ` Linus Torvalds
2024-06-13 0:12 ` [PATCH 2/2] vfs: move d_lockref out of the area used by RCU lookup Mateusz Guzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240618-spotten-scheren-0c87d248419f@brauner \
--to=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjguzik@gmail.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).