From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C1B8158A03 for ; Tue, 25 Jun 2024 13:35:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719322521; cv=none; b=Llql/+Faehk5AT3KmHNKfRV9j+pgHrvQCRJUARCqDVL3d5FqIftdbMDZbw7wa/QP5Mg9M0Eacef6J8NIK6VbPH4gQt3CGwc2pHFC5lPgogHWZK8o0oGTU6T96RN5DFFB6dNqtk0tjsBXeoI798rAMRo28VcqbCDn5pRr6st2+SU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719322521; c=relaxed/simple; bh=KMdy91uKputWU2twb5nzi2YXMNDuIeLpAJpKLxCGtek=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=P1woTOxFyMsr4HBFAPBfJFx+aate7USdSMyZBD+HoYXedfCH2h4VjQRmSzgWQTWLKgTdkZSNj6uNA0R9MI4qjoJknpBs9v74Sda0TGDZABt45MTAttKUbWrccPk5dRABuM4r0pIc2V84Y9Q4PT9bmI4DiWoR3NoVoa+KC2OTBOo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=bi3S/THY; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bi3S/THY" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6F573C32786; Tue, 25 Jun 2024 13:35:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719322520; bh=KMdy91uKputWU2twb5nzi2YXMNDuIeLpAJpKLxCGtek=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bi3S/THYzceW/Cje4nA6lReRcOaQYOISdjpCX/Ba0dL34rCH8OqI78dNx6VOUODyP IWYQKlKgVJYWEjeKamfk0M0e80AKyA9ix1CDuS0G9OV5sM2VZ12dF3UR0ZnbZzy4ff W0e6aWR6V+lSSq9LXjorGq+TvMuLhKpcExCG+rVVMUYS1l2u7Pl4Zztp0uvDvmtnxx LNbAq/eyNwe7XUxPjWjhthCZ+KDmro4YKdQpkTP2R2PKeiZVE3kbgWIxuymb1/mPlz 9Sl72dZiqWTdZ0myKckFCtatsLzdh2P7CgnNmD37eHaQATYhph9p3owINUc3SEIxg4 HpdUUV9Jz/s/Q== Date: Tue, 25 Jun 2024 15:35:17 +0200 From: Christian Brauner To: Miklos Szeredi Cc: Josef Bacik , linux-fsdevel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH 0/4] Add the ability to query mount options in statmount Message-ID: <20240625-beackern-bahnstation-290299dade30@brauner> References: <20240625-tragbar-sitzgelegenheit-48f310320058@brauner> <20240625130008.GA2945924@perftesting> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: On Tue, Jun 25, 2024 at 03:04:40PM GMT, Miklos Szeredi wrote: > On Tue, 25 Jun 2024 at 15:00, Josef Bacik wrote: > > > We could go this way I suppose, but again this is a lot of work, and honestly I > > just want to log mount options into some database so I can go looking for people > > doing weird shit on my giant fleet of machines/containers. Would the iter thing > > make the overlayfs thing better? Yeah for sure. Do we care? I don't think so, > > we just want all the options, and we can all strsep/strtok with a comma. > > I think we can live with the monolithic option block. However I'd > prefer the separator to be a null character, thus the options could be > sent unescaped. That way the iterator will be a lot simpler to > implement. For libmount it means writing a new parser and Karel prefers the "," format so I would like to keep the current format.