From: Josef Bacik <josef@toxicpanda.com>
To: Hanna Czenczek <hreitz@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-doc@vger.kernel.org, virtualization@lists.linux.dev,
"Miklos Szeredi" <mszeredi@redhat.com>,
"German Maglione" <gmaglione@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Eugenio Pérez" <eperezma@redhat.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"Vivek Goyal" <vgoyal@redhat.com>
Subject: Re: [PATCH 0/2] virtio-fs: Add 'file' mount option
Date: Tue, 9 Jul 2024 13:56:52 -0400 [thread overview]
Message-ID: <20240709175652.GB1040492@perftesting> (raw)
In-Reply-To: <20240709111918.31233-1-hreitz@redhat.com>
On Tue, Jul 09, 2024 at 01:19:16PM +0200, Hanna Czenczek wrote:
> Hi,
>
> We want to be able to mount filesystems that just consist of one regular
> file via virtio-fs, i.e. no root directory, just a file as the root
> node.
>
> While that is possible via FUSE itself (through the 'rootmode' mount
> option, which is automatically set by the fusermount help program to
> match the mount point's inode mode), there is no virtio-fs option yet
> that would allow changing the rootmode from S_IFDIR to S_IFREG.
>
> To do that, this series introduces a new 'file' mount option that does
> precisely that. Alternatively, we could provide the same 'rootmode'
> option that FUSE has, but as laid out in patch 1's commit description,
> that option is a bit cumbersome for virtio-fs (in a way that it is not
> for FUSE), and its usefulness as a more general option is limited.
>
All this does is make file an alias for something a little easier for users to
read, which can easily be done in libfuse. Add the code to lib/mount.c to alias
'file' to turn it into rootmode=S_IFREG when it sends it to the kernel, it's not
necessary to do this in the kernel. Thanks,
Josef
next prev parent reply other threads:[~2024-07-09 17:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-09 11:19 [PATCH 0/2] virtio-fs: Add 'file' mount option Hanna Czenczek
2024-07-09 11:19 ` [PATCH 1/2] " Hanna Czenczek
2024-07-09 11:19 ` [PATCH 2/2] virtio-fs: Document " Hanna Czenczek
2024-07-09 17:56 ` Josef Bacik [this message]
2024-07-10 7:28 ` [PATCH 0/2] virtio-fs: Add " Hanna Czenczek
2024-07-10 18:42 ` Josef Bacik
2024-07-11 8:21 ` Hanna Czenczek
2024-07-11 14:27 ` Hanna Czenczek
2024-07-11 14:34 ` Josef Bacik
2024-07-11 15:04 ` Hanna Czenczek
2024-07-10 17:28 ` Stefan Hajnoczi
2024-07-11 8:31 ` Hanna Czenczek
2024-08-29 8:07 ` Miklos Szeredi
2024-08-29 12:37 ` Hanna Czenczek
2024-08-29 13:07 ` Miklos Szeredi
[not found] ` <b82dd5f9-a214-4a13-b500-38b07f1e9761@redhat.com>
2024-08-29 13:21 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240709175652.GB1040492@perftesting \
--to=josef@toxicpanda.com \
--cc=corbet@lwn.net \
--cc=eperezma@redhat.com \
--cc=gmaglione@redhat.com \
--cc=hreitz@redhat.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mszeredi@redhat.com \
--cc=stefanha@redhat.com \
--cc=vgoyal@redhat.com \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).