From: David Sterba <dsterba@suse.cz>
To: Kees Cook <kees@kernel.org>
Cc: David Sterba <dsterba@suse.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH] fs/affs: struct slink_front: Replace 1-element array with flexible array
Date: Thu, 11 Jul 2024 16:29:28 +0200 [thread overview]
Message-ID: <20240711142928.GB8022@suse.cz> (raw)
In-Reply-To: <20240710225734.work.823-kees@kernel.org>
On Wed, Jul 10, 2024 at 03:57:34PM -0700, Kees Cook wrote:
> Replace the deprecated[1] use of a 1-element array in
> struct slink_front with a modern flexible array.
>
> No binary differences are present after this conversion.
>
> Link: https://github.com/KSPP/linux/issues/79 [1]
> Signed-off-by: Kees Cook <kees@kernel.org>
Thanks, I've added the 3 patches to my tree. I've noticed there's one
more 1-element array in struct affs_root_head (hashtable):
https://elixir.bootlin.com/linux/latest/source/fs/affs/amigaffs.h#L50
The struct is used only partially by AFFS_ROOT_HEAD from affs_fill_super
and not accessing the hashtable. This could have been missed by the
tools you use or was the conversion intentionally skipped?
next prev parent reply other threads:[~2024-07-11 14:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-10 22:57 [PATCH] fs/affs: struct slink_front: Replace 1-element array with flexible array Kees Cook
2024-07-10 23:23 ` Gustavo A. R. Silva
2024-07-11 14:29 ` David Sterba [this message]
2024-07-11 16:05 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240711142928.GB8022@suse.cz \
--to=dsterba@suse.cz \
--cc=dsterba@suse.com \
--cc=kees@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).