From: Al Viro <viro@zeniv.linux.org.uk>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: linux-fsdevel@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 01/10] ufs: Convert ufs_get_page() to use a folio
Date: Tue, 16 Jul 2024 23:31:03 +0100 [thread overview]
Message-ID: <20240716223103.GA76604@ZenIV> (raw)
In-Reply-To: <20240709033029.1769992-2-willy@infradead.org>
On Tue, Jul 09, 2024 at 04:30:18AM +0100, Matthew Wilcox (Oracle) wrote:
> + struct folio *folio = read_mapping_folio(mapping, n, NULL);
> +
> + if (IS_ERR(folio))
> + return &folio->page;
return ERR_CAST(folio);
would be better here; yes, I realize it's going away in the next commit,
but it's easier to follow that way (and actually makes the next commit
easier to follow as well).
next prev parent reply other threads:[~2024-07-16 22:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-09 3:30 [PATCH 00/10] Convert UFS directory handling to folios Matthew Wilcox (Oracle)
2024-07-09 3:30 ` [PATCH 01/10] ufs: Convert ufs_get_page() to use a folio Matthew Wilcox (Oracle)
2024-07-16 22:31 ` Al Viro [this message]
2024-07-09 3:30 ` [PATCH 02/10] ufs: Convert ufs_get_page() to ufs_get_folio() Matthew Wilcox (Oracle)
2024-07-09 3:30 ` [PATCH 03/10] ufs: Convert ufs_check_page() to ufs_check_folio() Matthew Wilcox (Oracle)
2024-07-09 3:30 ` [PATCH 04/10] ufs: Convert ufs_find_entry() to take a folio Matthew Wilcox (Oracle)
2024-07-09 3:30 ` [PATCH 05/10] ufs: Convert ufs_set_link() and ufss_dotdot() " Matthew Wilcox (Oracle)
2024-07-09 3:30 ` [PATCH 06/10] ufs: Convert ufs_delete_entry() to work on " Matthew Wilcox (Oracle)
2024-07-09 3:30 ` [PATCH 07/10] ufs: Convert ufs_make_empty() to use " Matthew Wilcox (Oracle)
2024-07-09 3:30 ` [PATCH 08/10] ufs: Convert ufs_prepare_chunk() to take " Matthew Wilcox (Oracle)
2024-07-09 3:30 ` [PATCH 09/10] ufs; Convert ufs_commit_chunk() " Matthew Wilcox (Oracle)
2024-07-09 3:30 ` [PATCH 10/10] ufs: Convert directory handling to kmap_local Matthew Wilcox (Oracle)
2024-07-16 22:46 ` [PATCH 00/10] Convert UFS directory handling to folios Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240716223103.GA76604@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).