From: Yu Ma <yu.ma@intel.com>
To: brauner@kernel.org, jack@suse.cz, mjguzik@gmail.com, edumazet@google.com
Cc: yu.ma@intel.com, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, pan.deng@intel.com,
tianyou.li@intel.com, tim.c.chen@intel.com,
tim.c.chen@linux.intel.com, viro@zeniv.linux.org.uk
Subject: [PATCH v5 0/3] fs/file.c: optimize the critical section of file_lock in
Date: Wed, 17 Jul 2024 10:50:15 -0400 [thread overview]
Message-ID: <20240717145018.3972922-1-yu.ma@intel.com> (raw)
In-Reply-To: <20240614163416.728752-1-yu.ma@intel.com>
pts/blogbench-1.1.0 is a benchmark designed to replicate the
load of a real-world busy file server by multiple threads of
random reads, writes, and rewrites. When running default configuration
with multiple parallel threads, hot spin lock contention is observed
from alloc_fd(), file_closed_fd() and put_unused_fd() around file_lock.
These 3 patches are created to reduce the critical section of file_lock
in alloc_fd() and close_fd(). As a result, on top of patch 1,
pts/blogbench-1.1.0 has been improved by 22% for read and 8% for write
on Intel ICX 160 cores configuration with v6.10-rc7.
v4 -> v5:
Revised patch 3 for some code style issues.
v3 -> v4:
1. Rebased the patch set to v6.10-rc7 and updated performance results.
2. Updated patch 1 to revise the order of fd checking.
3. As proposed by Mateusz Guzik <mjguzik gmail.com>, and agreed by Jan Kara
<jack@suse.cz> and Tim Chen <tim.c.chen@linux.intel.com>, updated patch 3 with
a more generic and scalable fast path for the word contains next_fd.
v2 -> v3:
1. Rebased the patch set to latest v6.10-rc6 and updated the performance results
2. Reordered the patches as suggested by Mateusz Guzik <mjguzik gmail.com>
3. Updated the fast path from alloc_fd() to find_next_fd() as suggested by
Mateusz Guzik <mjguzik gmail.com> and Jan Kara <jack@suse.cz>, it is efficient
and more concise than v2.
v1 -> v2:
1. Rebased the patch set to latest v6.10-rc4 and updated the performance results
2. Fixed the bug identified by Mateusz Guzik in patch 1 with adding rlimit check
for fast path
3. Updated patch 3 to remove sanity_check directly per the alignment with
maintainer
Yu Ma (3):
fs/file.c: remove sanity_check and add likely/unlikely in alloc_fd()
fs/file.c: conditionally clear full_fds
fs/file.c: add fast path in find_next_fd()
fs/file.c | 46 ++++++++++++++++++++++++++--------------------
1 file changed, 26 insertions(+), 20 deletions(-)
--
2.43.0
next prev parent reply other threads:[~2024-07-17 14:24 UTC|newest]
Thread overview: 103+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-14 16:34 [PATCH 0/3] fs/file.c: optimize the critical section of Yu Ma
2024-06-14 16:34 ` [PATCH 1/3] fs/file.c: add fast path in alloc_fd() Yu Ma
2024-06-15 6:31 ` Mateusz Guzik
2024-06-16 4:01 ` Ma, Yu
2024-06-17 17:49 ` Tim Chen
2024-06-19 10:36 ` David Laight
2024-06-19 17:09 ` Ma, Yu
2024-06-14 16:34 ` [PATCH 2/3] fs/file.c: conditionally clear full_fds Yu Ma
2024-06-14 16:34 ` [PATCH 3/3] fs/file.c: move sanity_check from alloc_fd() to put_unused_fd() Yu Ma
2024-06-15 4:41 ` Mateusz Guzik
2024-06-15 5:07 ` Mateusz Guzik
2024-06-17 17:55 ` Tim Chen
2024-06-17 17:59 ` Mateusz Guzik
2024-06-17 18:04 ` Tim Chen
2024-06-18 8:35 ` Michal Hocko
2024-06-18 9:06 ` Mateusz Guzik
2024-06-18 20:40 ` Tim Chen
2024-06-16 3:47 ` Ma, Yu
2024-06-17 11:23 ` Mateusz Guzik
2024-06-17 17:22 ` Ma, Yu
2024-06-17 8:36 ` Christian Brauner
2024-06-22 15:49 ` [PATCH v2 0/3] fs/file.c: optimize the critical section of file_lock in Yu Ma
2024-06-22 15:49 ` [PATCH v2 1/3] fs/file.c: add fast path in alloc_fd() Yu Ma
2024-06-25 11:52 ` Jan Kara
2024-06-25 12:53 ` Jan Kara
2024-06-25 15:33 ` Ma, Yu
2024-06-26 11:54 ` Jan Kara
2024-06-26 16:43 ` Tim Chen
2024-06-26 16:52 ` Tim Chen
2024-06-27 12:09 ` Jan Kara
2024-06-27 12:20 ` Mateusz Guzik
2024-06-27 16:21 ` Tim Chen
2024-06-26 19:13 ` Mateusz Guzik
2024-06-27 14:03 ` Jan Kara
2024-06-27 15:33 ` Christian Brauner
2024-06-27 18:27 ` Ma, Yu
2024-06-27 19:59 ` Mateusz Guzik
2024-06-28 9:12 ` Jan Kara
2024-06-29 15:41 ` Ma, Yu
2024-06-29 15:46 ` Mateusz Guzik
2024-06-29 14:23 ` Ma, Yu
2024-06-22 15:49 ` [PATCH v2 2/3] fs/file.c: conditionally clear full_fds Yu Ma
2024-06-25 11:54 ` Jan Kara
2024-06-25 15:41 ` Ma, Yu
2024-06-22 15:49 ` [PATCH v2 3/3] fs/file.c: remove sanity_check from alloc_fd() Yu Ma
2024-06-25 12:08 ` Jan Kara
2024-06-25 13:09 ` Mateusz Guzik
2024-06-25 13:11 ` Mateusz Guzik
2024-06-25 13:30 ` Jan Kara
2024-06-26 13:10 ` Christian Brauner
2024-07-03 14:33 ` [PATCH v3 0/3] fs/file.c: optimize the critical section of file_lock in Yu Ma
2024-07-03 14:33 ` [PATCH v3 1/3] fs/file.c: remove sanity_check and add likely/unlikely in alloc_fd() Yu Ma
2024-07-03 14:34 ` Christian Brauner
2024-07-03 14:46 ` Ma, Yu
2024-07-04 10:11 ` Jan Kara
2024-07-04 14:45 ` Ma, Yu
2024-07-04 15:41 ` Jan Kara
2024-07-03 14:33 ` [PATCH v3 2/3] fs/file.c: conditionally clear full_fds Yu Ma
2024-07-03 14:33 ` [PATCH v3 3/3] fs/file.c: add fast path in find_next_fd() Yu Ma
2024-07-03 14:17 ` Mateusz Guzik
2024-07-03 14:28 ` Ma, Yu
2024-07-04 10:07 ` Jan Kara
2024-07-04 10:03 ` Jan Kara
2024-07-04 14:50 ` Ma, Yu
2024-07-04 17:44 ` Mateusz Guzik
2024-07-04 21:55 ` Jan Kara
2024-07-05 7:56 ` Ma, Yu
2024-07-09 8:32 ` Ma, Yu
2024-07-09 10:17 ` Mateusz Guzik
2024-07-10 23:40 ` Tim Chen
2024-07-11 9:27 ` Ma, Yu
2024-07-13 2:39 ` [PATCH v4 0/3] fs/file.c: optimize the critical section of file_lock in Yu Ma
2024-07-13 2:39 ` [PATCH v4 1/3] fs/file.c: remove sanity_check and add likely/unlikely in alloc_fd() Yu Ma
2024-07-16 11:11 ` Jan Kara
2024-07-13 2:39 ` [PATCH v4 2/3] fs/file.c: conditionally clear full_fds Yu Ma
2024-07-13 2:39 ` [PATCH v4 3/3] fs/file.c: add fast path in find_next_fd() Yu Ma
2024-07-16 11:19 ` Jan Kara
2024-07-16 12:37 ` Ma, Yu
2024-07-17 14:50 ` Yu Ma [this message]
2024-07-17 14:50 ` [PATCH v5 1/3] fs/file.c: remove sanity_check and add likely/unlikely in alloc_fd() Yu Ma
2024-08-06 13:44 ` kernel test robot
2024-08-14 21:38 ` Al Viro
2024-08-15 2:49 ` Ma, Yu
2024-08-15 3:45 ` Al Viro
2024-08-15 8:34 ` Ma, Yu
2024-10-31 7:42 ` Mateusz Guzik
2024-10-31 10:14 ` Christian Brauner
2024-07-17 14:50 ` [PATCH v5 2/3] fs/file.c: conditionally clear full_fds Yu Ma
2024-07-17 14:50 ` [PATCH v5 3/3] fs/file.c: add fast path in find_next_fd() Yu Ma
2024-07-19 17:53 ` Mateusz Guzik
2024-07-20 12:57 ` Ma, Yu
2024-07-20 14:22 ` Mateusz Guzik
2024-08-06 13:48 ` kernel test robot
2024-07-22 15:02 ` [PATCH v5 0/3] fs/file.c: optimize the critical section of file_lock in Christian Brauner
2024-08-01 19:13 ` Al Viro
2024-08-02 11:04 ` Christian Brauner
2024-08-02 14:22 ` Al Viro
2024-08-05 6:56 ` Christian Brauner
2024-08-12 1:31 ` Ma, Yu
2024-08-12 2:40 ` Al Viro
2024-08-12 15:09 ` Ma, Yu
2024-11-06 17:44 ` Jan Kara
2024-11-06 17:59 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240717145018.3972922-1-yu.ma@intel.com \
--to=yu.ma@intel.com \
--cc=brauner@kernel.org \
--cc=edumazet@google.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjguzik@gmail.com \
--cc=pan.deng@intel.com \
--cc=tianyou.li@intel.com \
--cc=tim.c.chen@intel.com \
--cc=tim.c.chen@linux.intel.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).