linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christian Brauner <brauner@kernel.org>
To: linux-fsdevel@vger.kernel.org
Cc: Josef Bacik <josef@toxicpanda.com>,
	Jeff Layton <jlayton@kernel.org>,  Karel Zak <kzak@redhat.com>,
	Stephane Graber <stgraber@stgraber.org>,
	 Christian Brauner <brauner@kernel.org>,
	 Alexander Mikhalitsyn <alexander@mihalicyn.com>
Subject: [PATCH RFC 4/5] file: add fput() cleanup helper
Date: Fri, 19 Jul 2024 13:41:51 +0200	[thread overview]
Message-ID: <20240719-work-mount-namespace-v1-4-834113cab0d2@kernel.org> (raw)
In-Reply-To: <20240719-work-mount-namespace-v1-0-834113cab0d2@kernel.org>

Add a simple helper to put a file reference.

Signed-off-by: Christian Brauner <brauner@kernel.org>
---
 include/linux/file.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/linux/file.h b/include/linux/file.h
index 237931f20739..d1e768b06069 100644
--- a/include/linux/file.h
+++ b/include/linux/file.h
@@ -11,6 +11,7 @@
 #include <linux/posix_types.h>
 #include <linux/errno.h>
 #include <linux/cleanup.h>
+#include <linux/err.h>
 
 struct file;
 
@@ -96,6 +97,7 @@ extern void put_unused_fd(unsigned int fd);
 
 DEFINE_CLASS(get_unused_fd, int, if (_T >= 0) put_unused_fd(_T),
 	     get_unused_fd_flags(flags), unsigned flags)
+DEFINE_FREE(fput, struct file *, if (!IS_ERR_OR_NULL(_T)) fput(_T))
 
 /*
  * take_fd() will take care to set @fd to -EBADF ensuring that

-- 
2.43.0


  parent reply	other threads:[~2024-07-19 11:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-19 11:41 [PATCH RFC 0/5] nsfs: iterate through mount namespaces Christian Brauner
2024-07-19 11:41 ` [PATCH RFC 1/5] fs: use all available ids Christian Brauner
2024-07-19 11:41 ` [PATCH RFC 2/5] fs: allow mount namespace fd Christian Brauner
2024-07-19 11:41 ` [PATCH RFC 3/5] fs: add put_mnt_ns() cleanup helper Christian Brauner
2024-07-19 11:41 ` Christian Brauner [this message]
2024-07-19 11:41 ` [PATCH RFC 5/5] nsfs: iterate through mount namespaces Christian Brauner
2024-07-19 14:53 ` [PATCH RFC 0/5] " Josef Bacik
2024-07-22 14:42 ` Jeff Layton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240719-work-mount-namespace-v1-4-834113cab0d2@kernel.org \
    --to=brauner@kernel.org \
    --cc=alexander@mihalicyn.com \
    --cc=jlayton@kernel.org \
    --cc=josef@toxicpanda.com \
    --cc=kzak@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=stgraber@stgraber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).