From: Christian Brauner <brauner@kernel.org>
To: jack@suse.cz, Haifeng Xu <haifeng.xu@shopee.com>
Cc: Christian Brauner <brauner@kernel.org>,
axboe@kernel.dk, tj@kernel.org, viro@zeniv.linux.org.uk,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] fs: don't flush in-flight wb switches for superblocks without cgroup writeback
Date: Fri, 26 Jul 2024 09:09:26 +0200 [thread overview]
Message-ID: <20240726-ermuntern-seeblick-5a1add765522@brauner> (raw)
In-Reply-To: <20240726030525.180330-1-haifeng.xu@shopee.com>
On Fri, 26 Jul 2024 11:05:25 +0800, Haifeng Xu wrote:
> When deactivating any type of superblock, it had to wait for the in-flight
> wb switches to be completed. wb switches are executed in inode_switch_wbs_work_fn()
> which needs to acquire the wb_switch_rwsem and races against sync_inodes_sb().
> If there are too much dirty data in the superblock, the waiting time may increase
> significantly.
>
> For superblocks without cgroup writeback such as tmpfs, they have nothing to
> do with the wb swithes, so the flushing can be avoided.
>
> [...]
Applied to the vfs.misc branch of the vfs/vfs.git tree.
Patches in the vfs.misc branch should appear in linux-next soon.
Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.
It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.
Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.misc
[1/1] fs: don't flush in-flight wb switches for superblocks without cgroup writeback
https://git.kernel.org/vfs/vfs/c/5f307d17dc72
next prev parent reply other threads:[~2024-07-26 7:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-25 2:39 [PATCH] fs: don't flush in-flight wb switches for superblocks without cgroup writeback Haifeng Xu
2024-07-25 8:42 ` Jan Kara
2024-07-26 1:55 ` Haifeng Xu
2024-07-26 3:05 ` [PATCH v2] " Haifeng Xu
2024-07-26 7:09 ` Christian Brauner [this message]
2024-07-29 11:10 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240726-ermuntern-seeblick-5a1add765522@brauner \
--to=brauner@kernel.org \
--cc=axboe@kernel.dk \
--cc=haifeng.xu@shopee.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox