From: Christoph Hellwig <hch@lst.de>
To: Florian Weimer <fweimer@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, Paul Eggert <eggert@cs.ucla.edu>,
libc-alpha@sourceware.org, linux-fsdevel@vger.kernel.org,
Trond Myklebust <trondmy@hammerspace.com>
Subject: Re: posix_fallocate behavior in glibc
Date: Tue, 30 Jul 2024 19:08:31 +0200 [thread overview]
Message-ID: <20240730170831.GA31915@lst.de> (raw)
In-Reply-To: <87o76ezua1.fsf@oldenburg.str.redhat.com>
On Tue, Jul 30, 2024 at 07:03:50PM +0200, Florian Weimer wrote:
> > The only relevant exception is probably ext4 in ext2/ext3 mode, where
> > the latter might still have users left running real workloads on it
> > and not using it for usb disks or VM images.
>
> Why doesn't the kernel perform allocation in these cases? There doesn't
> seem to be a file-system-specific reason why it's impossible to do.
Because in general it's a really stupid idea. You don't get a better
allocation patter, but you are writing every block twice, making things
significantly slower and wearing the device out in the process if it
is flash based.
> At the very least, we should have a variant of ftruncate that never
> truncates, likely under the fallocate umbrella. It seems that that's
> how posix_fallocate is used sometimes, for avoiding SIGBUS with mmap.
> To these use cases, whether extents are allocated or not does not
> matter.
I don't see how that is related.
> If we removed the fallback code from glibc today, it would just be
> EOPNOTSUPP that leaks to applications, so it's structurally the same
> issue.
Not really. EOPNOTSUPP is a valid error code, that has historically
been returned by other operating systems and even other libc
implementations for Linux
next prev parent reply other threads:[~2024-07-30 17:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-29 16:09 posix_fallocate behavior in glibc Christoph Hellwig
2024-07-29 17:23 ` Paul Eggert
2024-07-29 17:43 ` Christoph Hellwig
2024-07-29 17:54 ` Adhemerval Zanella Netto
[not found] ` <CAPBLoAf11hM0PLhqPG5gUyivU9U1manpOOhDWCPugUmWc1VVUw@mail.gmail.com>
2024-07-29 18:45 ` Christoph Hellwig
2024-07-29 17:57 ` Florian Weimer
2024-07-29 18:44 ` Christoph Hellwig
2024-07-29 18:52 ` Florian Weimer
2024-07-29 19:01 ` Christoph Hellwig
2024-07-29 19:23 ` Florian Weimer
2024-07-30 15:47 ` Christoph Hellwig
2024-07-30 16:11 ` Paul Eggert
2024-07-30 16:20 ` Christoph Hellwig
2024-07-30 17:03 ` Florian Weimer
2024-07-30 17:08 ` Christoph Hellwig [this message]
2024-07-30 17:29 ` Florian Weimer
2024-07-30 17:52 ` Mark Wielaard
2024-07-31 2:32 ` Theodore Ts'o
2024-07-29 23:53 ` Dave Chinner
-- strict thread matches above, loose matches on Subject: below --
2024-06-26 6:01 Christoph Hellwig
2024-07-29 15:09 ` Christoph Hellwig
2024-07-29 15:11 ` Sam James
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240730170831.GA31915@lst.de \
--to=hch@lst.de \
--cc=eggert@cs.ucla.edu \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=trondmy@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).