From: Oleg Nesterov <oleg@redhat.com>
To: Christian Brauner <brauner@kernel.org>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Aleksa Sarai <cyphar@cyphar.com>,
Tycho Andersen <tandersen@netflix.com>,
Daan De Meyer <daan.j.demeyer@gmail.com>,
Tejun Heo <tj@kernel.org>,
stable@vger.kernel.org
Subject: Re: [PATCH] pidfd: prevent creation of pidfds for kthreads
Date: Thu, 1 Aug 2024 15:59:01 +0200 [thread overview]
Message-ID: <20240801135900.GD4038@redhat.com> (raw)
In-Reply-To: <20240801-clever-mitleid-da9b4142edde@brauner>
On 08/01, Christian Brauner wrote:
>
> On Thu, Aug 01, 2024 at 10:01:20AM GMT, Oleg Nesterov wrote:
> > OK, I won't argue, but ....
> >
> > > you may or may not get notified
> > > via poll when a kthread exits.
> >
> > Why? the exiting kthread should not differ in this respect?
>
> Why do you want to allow it?
Again, I didn't try to "nack" your patch. Just tried to understand
your motivation.
And "may not get notified" above doesn't look right to me...
> > /proc/$pid/status has a "Kthread" field...
>
> Going forward, I don't want to force people to parse basic stuff out of
> procfs. Ideally, they'll be able to mostly rely on pidfd operations
> only.
Agreed.
Oleg.
next prev parent reply other threads:[~2024-08-01 13:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-31 10:01 [PATCH] pidfd: prevent creation of pidfds for kthreads Christian Brauner
2024-07-31 14:51 ` Oleg Nesterov
2024-08-01 6:58 ` Christian Brauner
2024-08-01 8:01 ` Oleg Nesterov
2024-08-01 13:48 ` Christian Brauner
2024-08-01 13:59 ` Oleg Nesterov [this message]
2024-08-18 3:58 ` Eric Biggers
2024-08-19 8:41 ` Christian Brauner
2024-08-20 19:34 ` Eric Biggers
2024-08-21 7:41 ` Christian Brauner
2024-08-21 7:47 ` Daan De Meyer
2024-08-23 5:23 ` Linux regression tracking (Thorsten Leemhuis)
2024-08-23 6:12 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240801135900.GD4038@redhat.com \
--to=oleg@redhat.com \
--cc=brauner@kernel.org \
--cc=cyphar@cyphar.com \
--cc=daan.j.demeyer@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tandersen@netflix.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).