linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lizhi Xu <lizhi.xu@windriver.com>
To: <jack@suse.cz>
Cc: <brauner@kernel.org>, <linux-fsdevel@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <lizhi.xu@windriver.com>,
	<phillip@squashfs.org.uk>, <squashfs-devel@lists.sourceforge.net>,
	<syzbot+24ac24ff58dc5b0d26b9@syzkaller.appspotmail.com>,
	<syzkaller-bugs@googlegroups.com>, <viro@zeniv.linux.org.uk>
Subject: [PATCH V5] squashfs: Add i_size check in squash_read_inode
Date: Fri, 2 Aug 2024 19:16:40 +0800	[thread overview]
Message-ID: <20240802111640.2762325-1-lizhi.xu@windriver.com> (raw)
In-Reply-To: <20240802093310.twbwdi5hpgpth63z@quack3>

syzbot report KMSAN: uninit-value in pick_link, the root cause is that
squashfs_symlink_read_folio did not check the length, resulting in folio
not being initialized and did not return the corresponding error code.

The length is calculated from i_size, so it is necessary to add a check
when i_size is initialized to confirm that its value is correct, otherwise
an error -EINVAL will be returned. Strictly, the check only applies to the
symlink type. Add larger symlink check.

Reported-and-tested-by: syzbot+24ac24ff58dc5b0d26b9@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=24ac24ff58dc5b0d26b9
Signed-off-by: Lizhi Xu <lizhi.xu@windriver.com>
---
 fs/squashfs/inode.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/fs/squashfs/inode.c b/fs/squashfs/inode.c
index 16bd693d0b3a..6c5dd225482f 100644
--- a/fs/squashfs/inode.c
+++ b/fs/squashfs/inode.c
@@ -287,6 +287,11 @@ int squashfs_read_inode(struct inode *inode, long long ino)
 		inode->i_mode |= S_IFLNK;
 		squashfs_i(inode)->start = block;
 		squashfs_i(inode)->offset = offset;
+		if ((int)inode->i_size < 0 || inode->i_size > PAGE_SIZE) {
+			ERROR("Wrong i_size %d!\n", inode->i_size);
+			return -EINVAL;
+		}
+
 
 		if (type == SQUASHFS_LSYMLINK_TYPE) {
 			__le32 xattr;
-- 
2.43.0


  reply	other threads:[~2024-08-02 11:17 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-31  8:12 [syzbot] [squashfs?] KMSAN: uninit-value in pick_link syzbot
2024-08-01  2:27 ` [PATCH] filemap: Init the newly allocated folio memory to 0 for the filemap Lizhi Xu
2024-08-01  2:58   ` Al Viro
2024-08-01  5:28     ` Lizhi Xu
2024-08-01  7:10       ` Al Viro
2024-08-01  7:24         ` Al Viro
2024-08-01  8:12         ` Lizhi Xu
2024-08-01  9:13           ` Lizhi Xu
2024-08-01 12:42           ` Al Viro
2024-08-01 15:17             ` [PATCH V2] squashfs: Add length check in squashfs_symlink_read_folio Lizhi Xu
2024-08-01 15:30               ` Jan Kara
2024-08-02  1:39                 ` Lizhi Xu
2024-08-02  1:50                 ` [PATCH V3] squashfs: Add i_size check in squash_read_inode Lizhi Xu
2024-08-02  3:01                   ` [PATCH V4] " Lizhi Xu
2024-08-02  9:33                     ` Jan Kara
2024-08-02 11:16                       ` Lizhi Xu [this message]
2024-08-02 13:52                         ` [PATCH V5] " Al Viro
2024-08-02 14:44                           ` [PATCH] filemap: Init the newly allocated folio memory to 0 for the filemap Lizhi Xu
2024-08-02 15:03                             ` Al Viro
2024-08-03  4:07                               ` [PATCH V6] squashfs: Add symlink size check in squash_read_inode Lizhi Xu
2024-08-03  7:43                                 ` [PATCH V7] " Lizhi Xu
2024-08-04 21:16                                   ` Phillip Lougher
2024-08-04 21:20                                     ` Al Viro
2024-08-04 22:31                                       ` Phillip Lougher
2024-08-05  7:03                                         ` Christian Brauner
2024-08-05  1:02                                       ` Lizhi Xu
2024-08-05  1:40                                         ` Al Viro
2024-08-06  2:56                                           ` Lizhi Xu
2024-08-06  4:59                                             ` Al Viro
2024-08-06  6:19                                               ` Lizhi Xu
2024-08-06  6:58                                                 ` Al Viro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240802111640.2762325-1-lizhi.xu@windriver.com \
    --to=lizhi.xu@windriver.com \
    --cc=brauner@kernel.org \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=phillip@squashfs.org.uk \
    --cc=squashfs-devel@lists.sourceforge.net \
    --cc=syzbot+24ac24ff58dc5b0d26b9@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).