From: Al Viro <viro@zeniv.linux.org.uk>
To: Lizhi Xu <lizhi.xu@windriver.com>
Cc: brauner@kernel.org, jack@suse.cz, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, phillip@squashfs.org.uk,
squashfs-devel@lists.sourceforge.net,
syzbot+24ac24ff58dc5b0d26b9@syzkaller.appspotmail.com,
syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH] filemap: Init the newly allocated folio memory to 0 for the filemap
Date: Fri, 2 Aug 2024 16:03:48 +0100 [thread overview]
Message-ID: <20240802150348.GW5334@ZenIV> (raw)
In-Reply-To: <20240802144415.259364-1-lizhi.xu@windriver.com>
On Fri, Aug 02, 2024 at 10:44:15PM +0800, Lizhi Xu wrote:
> On Fri, 2 Aug 2024 14:52:14 +0100, Al Viro wrote:
> > > + ERROR("Wrong i_size %d!\n", inode->i_size);
> > > + return -EINVAL;
> > > + }
> >
> > ITYM something like
> I do not recommend this type of code, as it would add unnecessary calls
> to le32_o_cpu compared to directly using i_size.
> > if (le32_to_cpu(sqsh_ino->symlink_size) > PAGE_SIZE) {
> > ERROR("Corrupted symlink\n");
> > return -EINVAL;
> > }
You do realize that it's inlined, right? Seriously, compare the
generated code...
next prev parent reply other threads:[~2024-08-02 15:03 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-31 8:12 [syzbot] [squashfs?] KMSAN: uninit-value in pick_link syzbot
2024-08-01 2:27 ` [PATCH] filemap: Init the newly allocated folio memory to 0 for the filemap Lizhi Xu
2024-08-01 2:58 ` Al Viro
2024-08-01 5:28 ` Lizhi Xu
2024-08-01 7:10 ` Al Viro
2024-08-01 7:24 ` Al Viro
2024-08-01 8:12 ` Lizhi Xu
2024-08-01 9:13 ` Lizhi Xu
2024-08-01 12:42 ` Al Viro
2024-08-01 15:17 ` [PATCH V2] squashfs: Add length check in squashfs_symlink_read_folio Lizhi Xu
2024-08-01 15:30 ` Jan Kara
2024-08-02 1:39 ` Lizhi Xu
2024-08-02 1:50 ` [PATCH V3] squashfs: Add i_size check in squash_read_inode Lizhi Xu
2024-08-02 3:01 ` [PATCH V4] " Lizhi Xu
2024-08-02 9:33 ` Jan Kara
2024-08-02 11:16 ` [PATCH V5] " Lizhi Xu
2024-08-02 13:52 ` Al Viro
2024-08-02 14:44 ` [PATCH] filemap: Init the newly allocated folio memory to 0 for the filemap Lizhi Xu
2024-08-02 15:03 ` Al Viro [this message]
2024-08-03 4:07 ` [PATCH V6] squashfs: Add symlink size check in squash_read_inode Lizhi Xu
2024-08-03 7:43 ` [PATCH V7] " Lizhi Xu
2024-08-04 21:16 ` Phillip Lougher
2024-08-04 21:20 ` Al Viro
2024-08-04 22:31 ` Phillip Lougher
2024-08-05 7:03 ` Christian Brauner
2024-08-05 1:02 ` Lizhi Xu
2024-08-05 1:40 ` Al Viro
2024-08-06 2:56 ` Lizhi Xu
2024-08-06 4:59 ` Al Viro
2024-08-06 6:19 ` Lizhi Xu
2024-08-06 6:58 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240802150348.GW5334@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizhi.xu@windriver.com \
--cc=phillip@squashfs.org.uk \
--cc=squashfs-devel@lists.sourceforge.net \
--cc=syzbot+24ac24ff58dc5b0d26b9@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).