From: Al Viro <viro@zeniv.linux.org.uk>
To: Mateusz Guzik <mjguzik@gmail.com>
Cc: brauner@kernel.org, jack@suse.cz, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] vfs: avoid spurious dentry ref/unref cycle on open
Date: Wed, 7 Aug 2024 21:38:14 +0100 [thread overview]
Message-ID: <20240807203814.GA5334@ZenIV> (raw)
In-Reply-To: <20240807124348.GY5334@ZenIV>
On Wed, Aug 07, 2024 at 01:43:48PM +0100, Al Viro wrote:
> On Wed, Aug 07, 2024 at 11:50:50AM +0200, Mateusz Guzik wrote:
>
> > tripping ip:
> > vfs_tmpfile+0x162/0x230:
> > fsnotify_parent at include/linux/fsnotify.h:81
> > (inlined by) fsnotify_file at include/linux/fsnotify.h:131
> > (inlined by) fsnotify_open at include/linux/fsnotify.h:401
> > (inlined by) vfs_tmpfile at fs/namei.c:3781
>
> Try this for incremental; missed the fact that finish_open() is
> used by ->tmpfile() instances, not just ->atomic_open().
>
> Al, crawling back to sleep...
I _really_ hate ->atomic_open() calling conventions; FWIW, I suspect
that in the current form this series is OK, but only because none
of the existing instances call finish_open() on a preexisting
aliases found by d_splice_alias(). And control flow in the
instances (especially the cleanup paths) is bloody awful...
We never got it quite right, and while the previous iterations of
the calling conventions for that methods had been worse, it's still
nasty in the current form ;-/
Oh, well - review of those has been long overdue.
next prev parent reply other threads:[~2024-08-07 20:38 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-06 14:46 [PATCH] vfs: avoid spurious dentry ref/unref cycle on open Mateusz Guzik
2024-08-06 15:53 ` Al Viro
2024-08-06 16:09 ` Mateusz Guzik
2024-08-06 16:14 ` Mateusz Guzik
2024-08-07 3:38 ` Al Viro
2024-08-07 3:57 ` Mateusz Guzik
2024-08-07 5:32 ` Al Viro
2024-08-07 5:46 ` Mateusz Guzik
2024-08-07 6:23 ` Al Viro
2024-08-07 6:33 ` Al Viro
2024-08-07 6:40 ` Mateusz Guzik
2024-08-07 7:05 ` Al Viro
2024-08-07 7:22 ` Mateusz Guzik
2024-08-07 7:52 ` Al Viro
2024-08-07 7:59 ` Mateusz Guzik
2024-08-07 9:50 ` Mateusz Guzik
2024-08-07 12:43 ` Al Viro
2024-08-07 20:38 ` Al Viro [this message]
2024-08-20 11:38 ` Mateusz Guzik
2024-08-22 0:33 ` Al Viro
2024-08-22 0:34 ` [PATCH 1/3] don't duplicate vfs_open() in kernel_file_open() Al Viro
2024-08-22 7:53 ` Christian Brauner
2024-08-22 0:41 ` [PATCH 2/3] lift grabbing path into caller of do_dentry_open() Al Viro
2024-08-22 7:54 ` Christian Brauner
2024-08-22 0:41 ` [PATCH 3/3] avoid extra path_get/path_put cycle in path_openat() Al Viro
2024-08-22 9:31 ` Christian Brauner
2024-08-22 10:21 ` Mateusz Guzik
2025-02-17 8:03 ` [PATCH] vfs: avoid spurious dentry ref/unref cycle on open Mateusz Guzik
2024-08-08 6:26 ` Mateusz Guzik
2024-08-06 22:51 ` Dave Chinner
2024-08-06 22:55 ` Mateusz Guzik
2024-08-07 2:56 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240807203814.GA5334@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjguzik@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).