From: Kees Cook <kees@kernel.org>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: Luis Chamberlain <mcgrof@kernel.org>,
Joel Granados <j.granados@samsung.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] sysctl: update comments to new registration APIs
Date: Mon, 12 Aug 2024 11:11:06 -0700 [thread overview]
Message-ID: <202408121110.C3838E62@keescook> (raw)
In-Reply-To: <20240810-sysctl-procname-null-comment-v1-1-816cd335de1b@weissschuh.net>
On Sat, Aug 10, 2024 at 07:00:35PM +0200, Thomas Weißschuh wrote:
> The sysctl registration APIs do not need a terminating table entry
> anymore and with commit acc154691fc7 ("sysctl: Warn on an empty procname element")
> even emit warnings if such a sentinel entry is supplied.
>
> While at it also remove the mention of "table->de" which was removed in
> commit 3fbfa98112fc ("[PATCH] sysctl: remove the proc_dir_entry member for the sysctl tables")
> back in 2007.
>
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
Thanks!
Reviewed-by: Kees Cook <kees@kernel.org>
If you're already poking around at these things, it might also be nice
to add full kern-doc for these APIs and structs.
--
Kees Cook
next prev parent reply other threads:[~2024-08-12 18:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-10 17:00 [PATCH] sysctl: update comments to new registration APIs Thomas Weißschuh
2024-08-12 18:11 ` Kees Cook [this message]
2024-10-23 13:32 ` Joel Granados
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202408121110.C3838E62@keescook \
--to=kees@kernel.org \
--cc=j.granados@samsung.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=mcgrof@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).