From: Christoph Hellwig <hch@lst.de>
To: Matthew Wilcox <willy@infradead.org>
Cc: Christoph Hellwig <hch@lst.de>,
Chandan Babu R <chandan.babu@oracle.com>,
"Darrick J. Wong" <djwong@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/3] xfs: convert perag lookup to xarray
Date: Mon, 12 Aug 2024 16:43:11 +0200 [thread overview]
Message-ID: <20240812144311.GA29114@lst.de> (raw)
In-Reply-To: <ZroepUyYganq8UHJ@casper.infradead.org>
On Mon, Aug 12, 2024 at 03:39:33PM +0100, Matthew Wilcox wrote:
> > + rcu_read_lock();
> > + xa_for_each_marked(&mp->m_perags, index, pag, XFS_ICI_RECLAIM_TAG) {
> > + trace_xfs_reclaim_inodes_count(pag, _THIS_IP_);
> > reclaimable += pag->pag_ici_reclaimable;
> > - xfs_perag_put(pag);
> > }
> > + rcu_read_unlock();
>
> Would you rather use xas_for_each_marked() here? O(n) rather than
> O(n.log(n)).
>
> Other than that, looks like a straightforward and correct conversion.
That probably would be more efficient, but the API feels like awkward
due to the required end argument on top of the slightly cumbersome
but not really horrible caller provided XA_STATE().
Is there any good reason why there's isn't an O(1) version that is
just as simple to use as xa_for_each_marked?
next prev parent reply other threads:[~2024-08-12 14:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-12 6:30 conver XFS perag lookup to xarrays Christoph Hellwig
2024-08-12 6:31 ` [PATCH 1/3] xarray: add xa_set Christoph Hellwig
2024-08-12 12:25 ` Matthew Wilcox
2024-08-12 12:28 ` Christoph Hellwig
2024-08-12 6:31 ` [PATCH 2/3] xfs: convert perag lookup to xarray Christoph Hellwig
2024-08-12 14:39 ` Matthew Wilcox
2024-08-12 14:43 ` Christoph Hellwig [this message]
2024-08-12 16:39 ` Pankaj Raghav (Samsung)
2024-08-12 19:02 ` Matthew Wilcox
2024-08-13 8:30 ` Pankaj Raghav (Samsung)
2024-08-13 6:37 ` kernel test robot
2024-08-14 4:59 ` Dave Chinner
2024-08-14 5:21 ` Christoph Hellwig
2024-08-12 6:31 ` [PATCH 3/3] xfs: use kfree_rcu_mightsleep to free the perag structures Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240812144311.GA29114@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=chandan.babu@oracle.com \
--cc=djwong@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).