From: kernel test robot <lkp@intel.com>
To: Christoph Hellwig <hch@lst.de>,
Chandan Babu R <chandan.babu@oracle.com>,
Matthew Wilcox <willy@infradead.org>
Cc: oe-kbuild-all@lists.linux.dev,
"Darrick J. Wong" <djwong@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Memory Management List <linux-mm@kvack.org>,
linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/3] xfs: convert perag lookup to xarray
Date: Tue, 13 Aug 2024 14:37:52 +0800 [thread overview]
Message-ID: <202408131403.L5SrjEa7-lkp@intel.com> (raw)
In-Reply-To: <20240812063143.3806677-3-hch@lst.de>
Hi Christoph,
kernel test robot noticed the following build warnings:
[auto build test WARNING on xfs-linux/for-next]
[also build test WARNING on akpm-mm/mm-nonmm-unstable linus/master v6.11-rc3 next-20240813]
[cannot apply to djwong-xfs/djwong-devel]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Christoph-Hellwig/xfs-convert-perag-lookup-to-xarray/20240812-183447
base: https://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git for-next
patch link: https://lore.kernel.org/r/20240812063143.3806677-3-hch%40lst.de
patch subject: [PATCH 2/3] xfs: convert perag lookup to xarray
config: x86_64-randconfig-122-20240813 (https://download.01.org/0day-ci/archive/20240813/202408131403.L5SrjEa7-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-12) 11.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240813/202408131403.L5SrjEa7-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202408131403.L5SrjEa7-lkp@intel.com/
sparse warnings: (new ones prefixed by >>)
>> fs/xfs/xfs_icache.c:1776:9: sparse: sparse: incorrect type in argument 4 (different base types) @@ expected restricted xa_mark_t [usertype] @@ got unsigned int enum xfs_icwalk_goal goal @@
fs/xfs/xfs_icache.c:1776:9: sparse: expected restricted xa_mark_t [usertype]
fs/xfs/xfs_icache.c:1776:9: sparse: got unsigned int enum xfs_icwalk_goal goal
>> fs/xfs/xfs_icache.c:1776:9: sparse: sparse: incorrect type in argument 4 (different base types) @@ expected restricted xa_mark_t [usertype] @@ got unsigned int enum xfs_icwalk_goal goal @@
fs/xfs/xfs_icache.c:1776:9: sparse: expected restricted xa_mark_t [usertype]
fs/xfs/xfs_icache.c:1776:9: sparse: got unsigned int enum xfs_icwalk_goal goal
>> fs/xfs/xfs_icache.c:244:51: sparse: sparse: incorrect type in argument 3 (different base types) @@ expected restricted xa_mark_t [usertype] @@ got unsigned int tag @@
fs/xfs/xfs_icache.c:244:51: sparse: expected restricted xa_mark_t [usertype]
fs/xfs/xfs_icache.c:244:51: sparse: got unsigned int tag
fs/xfs/xfs_icache.c:286:53: sparse: sparse: incorrect type in argument 3 (different base types) @@ expected restricted xa_mark_t [usertype] @@ got unsigned int tag @@
fs/xfs/xfs_icache.c:286:53: sparse: expected restricted xa_mark_t [usertype]
fs/xfs/xfs_icache.c:286:53: sparse: got unsigned int tag
>> fs/xfs/xfs_icache.c:1379:9: sparse: sparse: incorrect type in argument 4 (different base types) @@ expected restricted xa_mark_t [usertype] @@ got int @@
fs/xfs/xfs_icache.c:1379:9: sparse: expected restricted xa_mark_t [usertype]
fs/xfs/xfs_icache.c:1379:9: sparse: got int
>> fs/xfs/xfs_icache.c:1379:9: sparse: sparse: incorrect type in argument 4 (different base types) @@ expected restricted xa_mark_t [usertype] @@ got int @@
fs/xfs/xfs_icache.c:1379:9: sparse: expected restricted xa_mark_t [usertype]
fs/xfs/xfs_icache.c:1379:9: sparse: got int
fs/xfs/xfs_icache.c:1509:9: sparse: sparse: incorrect type in argument 4 (different base types) @@ expected restricted xa_mark_t [usertype] @@ got int @@
fs/xfs/xfs_icache.c:1509:9: sparse: expected restricted xa_mark_t [usertype]
fs/xfs/xfs_icache.c:1509:9: sparse: got int
fs/xfs/xfs_icache.c:1509:9: sparse: sparse: incorrect type in argument 4 (different base types) @@ expected restricted xa_mark_t [usertype] @@ got int @@
fs/xfs/xfs_icache.c:1509:9: sparse: expected restricted xa_mark_t [usertype]
fs/xfs/xfs_icache.c:1509:9: sparse: got int
fs/xfs/xfs_icache.c:1515:9: sparse: sparse: incorrect type in argument 4 (different base types) @@ expected restricted xa_mark_t [usertype] @@ got int @@
fs/xfs/xfs_icache.c:1515:9: sparse: expected restricted xa_mark_t [usertype]
fs/xfs/xfs_icache.c:1515:9: sparse: got int
fs/xfs/xfs_icache.c:1515:9: sparse: sparse: incorrect type in argument 4 (different base types) @@ expected restricted xa_mark_t [usertype] @@ got int @@
fs/xfs/xfs_icache.c:1515:9: sparse: expected restricted xa_mark_t [usertype]
fs/xfs/xfs_icache.c:1515:9: sparse: got int
fs/xfs/xfs_icache.c: note: in included file (through include/linux/rbtree.h, include/linux/mm_types.h, include/linux/mmzone.h, ...):
include/linux/rcupdate.h:869:25: sparse: sparse: context imbalance in 'xfs_iget_recycle' - unexpected unlock
fs/xfs/xfs_icache.c:580:28: sparse: sparse: context imbalance in 'xfs_iget_cache_hit' - different lock contexts for basic block
vim +1776 fs/xfs/xfs_icache.c
1762
1763 /* Walk all incore inodes to achieve a given goal. */
1764 static int
1765 xfs_icwalk(
1766 struct xfs_mount *mp,
1767 enum xfs_icwalk_goal goal,
1768 struct xfs_icwalk *icw)
1769 {
1770 struct xfs_perag *pag;
1771 int error = 0;
1772 int last_error = 0;
1773 unsigned long index = 0;
1774
1775 rcu_read_lock();
> 1776 xa_for_each_marked(&mp->m_perags, index, pag, goal) {
1777 if (!atomic_inc_not_zero(&pag->pag_active_ref))
1778 continue;
1779 rcu_read_unlock();
1780
1781 error = xfs_icwalk_ag(pag, goal, icw);
1782 xfs_perag_rele(pag);
1783
1784 rcu_read_lock();
1785 if (error) {
1786 last_error = error;
1787 if (error == -EFSCORRUPTED)
1788 break;
1789 }
1790 }
1791 rcu_read_unlock();
1792
1793 return last_error;
1794 BUILD_BUG_ON(XFS_ICWALK_PRIVATE_FLAGS & XFS_ICWALK_FLAGS_VALID);
1795 }
1796
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2024-08-13 6:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-12 6:30 conver XFS perag lookup to xarrays Christoph Hellwig
2024-08-12 6:31 ` [PATCH 1/3] xarray: add xa_set Christoph Hellwig
2024-08-12 12:25 ` Matthew Wilcox
2024-08-12 12:28 ` Christoph Hellwig
2024-08-12 6:31 ` [PATCH 2/3] xfs: convert perag lookup to xarray Christoph Hellwig
2024-08-12 14:39 ` Matthew Wilcox
2024-08-12 14:43 ` Christoph Hellwig
2024-08-12 16:39 ` Pankaj Raghav (Samsung)
2024-08-12 19:02 ` Matthew Wilcox
2024-08-13 8:30 ` Pankaj Raghav (Samsung)
2024-08-13 6:37 ` kernel test robot [this message]
2024-08-14 4:59 ` Dave Chinner
2024-08-14 5:21 ` Christoph Hellwig
2024-08-12 6:31 ` [PATCH 3/3] xfs: use kfree_rcu_mightsleep to free the perag structures Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202408131403.L5SrjEa7-lkp@intel.com \
--to=lkp@intel.com \
--cc=akpm@linux-foundation.org \
--cc=chandan.babu@oracle.com \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).