From: Al Viro <viro@zeniv.linux.org.uk>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: oe-kbuild@lists.linux.dev, lkp@intel.com,
oe-kbuild-all@lists.linux.dev, linux-fsdevel@vger.kernel.org
Subject: Re: [viro-vfs:work.fdtable 13/13] kernel/fork.c:3242 unshare_fd() warn: passing a valid pointer to 'PTR_ERR'
Date: Tue, 13 Aug 2024 19:16:00 +0100 [thread overview]
Message-ID: <20240813181600.GK13701@ZenIV> (raw)
In-Reply-To: <020d5bd0-2fae-481f-bc82-88e71de1137c@stanley.mountain>
On Tue, Aug 13, 2024 at 11:00:04AM +0300, Dan Carpenter wrote:
> 3f4b0acefd818e Al Viro 2024-08-06 3240 if (IS_ERR(*new_fdp)) {
> 3f4b0acefd818e Al Viro 2024-08-06 3241 *new_fdp = NULL;
> 3f4b0acefd818e Al Viro 2024-08-06 @3242 return PTR_ERR(new_fdp);
> ^^^^^^^^^^^^^^^^
> err = PTR_ERR(*new_fdp);
> *new_fdp = NULL;
> return err;
Argh... Obvious braino, but what it shows is that failures of that
thing are not covered by anything in e.g. LTP. Or in-kernel
self-tests, for that matter...
next prev parent reply other threads:[~2024-08-13 18:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-13 8:00 [viro-vfs:work.fdtable 13/13] kernel/fork.c:3242 unshare_fd() warn: passing a valid pointer to 'PTR_ERR' Dan Carpenter
2024-08-13 18:16 ` Al Viro [this message]
2024-08-14 1:03 ` Al Viro
2024-08-21 6:38 ` Shuah Khan
2024-08-22 0:15 ` Al Viro
2024-08-22 4:12 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240813181600.GK13701@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=dan.carpenter@linaro.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).