From: Joanne Koong <joannelkoong@gmail.com>
To: miklos@szeredi.hu, linux-fsdevel@vger.kernel.org
Cc: josef@toxicpanda.com, bernd.schubert@fastmail.fm,
jefflexu@linux.alibaba.com, laoar.shao@gmail.com,
kernel-team@meta.com
Subject: [PATCH v4 0/2] fuse: add timeout option for requests
Date: Tue, 13 Aug 2024 16:22:39 -0700 [thread overview]
Message-ID: <20240813232241.2369855-1-joannelkoong@gmail.com> (raw)
There are situations where fuse servers can become unresponsive or take
too long to reply to a request. Currently there is no upper bound on
how long a request may take, which may be frustrating to users who get
stuck waiting for a request to complete.
This patchset adds a timeout option for requests and two dynamically
configurable fuse sysctls "default_request_timeout" and "max_request_timeout"
for controlling/enforcing timeout behavior system-wide.
Existing fuse servers will not be affected unless they explicitly opt into the
timeout.
v3: https://lore.kernel.org/linux-fsdevel/20240808190110.3188039-1-joannelkoong@gmail.com/
Changes from v3 -> v4:
- Fix wording on some comments to make it more clear
- Use simpler logic for timer (eg remove extra if checks, use mod timer API) (Josef)
- Sanity-check should be on FR_FINISHING not FR_FINISHED (Jingbo)
- Fix comment for "processing queue", add req->fpq = NULL safeguard (Bernd)
v2: https://lore.kernel.org/linux-fsdevel/20240730002348.3431931-1-joannelkoong@gmail.com/
Changes from v2 -> v3:
- Disarm / rearm timer in dev_do_read to handle race conditions (Bernrd)
- Disarm timer in error handling for fatal interrupt (Yafang)
- Clean up do_fuse_request_end (Jingbo)
- Add timer for notify retrieve requests
- Fix kernel test robot errors for #define no-op functions
v1: https://lore.kernel.org/linux-fsdevel/20240717213458.1613347-1-joannelkoong@gmail.com/
Changes from v1 -> v2:
- Add timeout for background requests
- Handle resend race condition
- Add sysctls
Joanne Koong (2):
fuse: add optional kernel-enforced timeout for requests
fuse: add default_request_timeout and max_request_timeout sysctls
Documentation/admin-guide/sysctl/fs.rst | 17 +++
fs/fuse/Makefile | 2 +-
fs/fuse/dev.c | 192 +++++++++++++++++++++++-
fs/fuse/fuse_i.h | 30 ++++
fs/fuse/inode.c | 24 +++
fs/fuse/sysctl.c | 42 ++++++
6 files changed, 298 insertions(+), 9 deletions(-)
create mode 100644 fs/fuse/sysctl.c
--
2.43.5
next reply other threads:[~2024-08-13 23:23 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-13 23:22 Joanne Koong [this message]
2024-08-13 23:22 ` [PATCH v4 1/2] fuse: add optional kernel-enforced timeout for requests Joanne Koong
2024-08-21 7:55 ` Jingbo Xu
2024-08-21 17:38 ` Joanne Koong
2024-08-13 23:22 ` [PATCH v4 2/2] fuse: add default_request_timeout and max_request_timeout sysctls Joanne Koong
2024-08-20 6:39 ` Yafang Shao
2024-08-20 18:31 ` Joanne Koong
2024-08-21 2:00 ` Yafang Shao
2024-08-22 7:06 ` Jingbo Xu
2024-08-22 21:19 ` Joanne Koong
2024-08-23 2:17 ` Jingbo Xu
2024-08-23 22:54 ` Joanne Koong
2024-08-27 8:12 ` Jingbo Xu
2024-08-27 18:13 ` Joanne Koong
2024-08-28 2:27 ` Jingbo Xu
2024-08-21 2:01 ` [PATCH v4 0/2] fuse: add timeout option for requests Yafang Shao
2024-08-26 20:30 ` Joanne Koong
2024-08-21 13:47 ` Miklos Szeredi
2024-08-21 14:15 ` Bernd Schubert
2024-08-21 14:25 ` Miklos Szeredi
2024-08-21 18:11 ` Josef Bacik
2024-08-21 18:54 ` Miklos Szeredi
2024-08-21 21:22 ` Joanne Koong
2024-08-22 10:52 ` Miklos Szeredi
2024-08-22 17:31 ` Joanne Koong
2024-08-22 17:43 ` Miklos Szeredi
2024-08-22 22:38 ` Joanne Koong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240813232241.2369855-1-joannelkoong@gmail.com \
--to=joannelkoong@gmail.com \
--cc=bernd.schubert@fastmail.fm \
--cc=jefflexu@linux.alibaba.com \
--cc=josef@toxicpanda.com \
--cc=kernel-team@meta.com \
--cc=laoar.shao@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).