linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joanne Koong <joannelkoong@gmail.com>
To: miklos@szeredi.hu, linux-fsdevel@vger.kernel.org
Cc: josef@toxicpanda.com, bernd.schubert@fastmail.fm, kernel-team@meta.com
Subject: [PATCH 2/2] fuse: update stats for pages in dropped aux writeback list
Date: Mon, 19 Aug 2024 11:24:17 -0700	[thread overview]
Message-ID: <20240819182417.504672-2-joannelkoong@gmail.com> (raw)
In-Reply-To: <20240819182417.504672-1-joannelkoong@gmail.com>

In the case where the aux writeback list is dropped (eg the pages
have been truncated or the connection is broken), the stats for
its pages and backing device info need to be updated as well.

Fixes: e2653bd53a98 ("fuse: fix leaked aux requests")
Signed-off-by: Joanne Koong <joannelkoong@gmail.com>
---
 fs/fuse/file.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/fuse/file.c b/fs/fuse/file.c
index 63fd5fc6872e..7ac56be5fee6 100644
--- a/fs/fuse/file.c
+++ b/fs/fuse/file.c
@@ -1831,10 +1831,11 @@ __acquires(fi->lock)
 	fuse_writepage_finish(wpa);
 	spin_unlock(&fi->lock);
 
-	/* After fuse_writepage_finish() aux request list is private */
+	/* After rb_erase() aux request list is private */
 	for (aux = wpa->next; aux; aux = next) {
 		next = aux->next;
 		aux->next = NULL;
+		fuse_writepage_finish(aux);
 		fuse_writepage_free(aux);
 	}
 
-- 
2.43.5


  reply	other threads:[~2024-08-19 18:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-19 18:24 [PATCH 1/2] fuse: drop unused fuse_mount arg in fuse_writepage_finish Joanne Koong
2024-08-19 18:24 ` Joanne Koong [this message]
2024-08-20  2:10   ` [PATCH 2/2] fuse: update stats for pages in dropped aux writeback list Jingbo Xu
2024-08-20 18:21     ` Joanne Koong
2024-08-21 15:56   ` Miklos Szeredi
2024-08-21 18:26     ` Bernd Schubert
2024-08-21 20:22       ` Joanne Koong
2024-08-22 10:54         ` Miklos Szeredi
2024-08-20  1:53 ` [PATCH 1/2] fuse: drop unused fuse_mount arg in fuse_writepage_finish Jingbo Xu
2024-08-20 18:19   ` Joanne Koong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240819182417.504672-2-joannelkoong@gmail.com \
    --to=joannelkoong@gmail.com \
    --cc=bernd.schubert@fastmail.fm \
    --cc=josef@toxicpanda.com \
    --cc=kernel-team@meta.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).