From: Christoph Hellwig <hch@lst.de>
To: Brian Foster <bfoster@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>,
Christian Brauner <brauner@kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Chandan Babu R <chandan.babu@oracle.com>,
Jens Axboe <axboe@kernel.dk>, Jan Kara <jack@suse.cz>,
"Darrick J. Wong" <djwong@kernel.org>,
Theodore Ts'o <tytso@mit.edu>,
linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 6/6] xfs: refactor xfs_file_fallocate
Date: Wed, 21 Aug 2024 14:57:56 +0200 [thread overview]
Message-ID: <20240821125756.GA21319@lst.de> (raw)
In-Reply-To: <ZsXhL_pJhq2qyy-l@bfoster>
On Wed, Aug 21, 2024 at 08:44:31AM -0400, Brian Foster wrote:
> > + error = xfs_reflink_unshare(XFS_I(inode), offset, len);
> > + if (error)
> > + return error;
> > +
>
> Doesn't unshare imply alloc?
Yes, ooks like that got lost and no test noticed it
> > - if (xfs_file_sync_writes(file))
> > + if (!error && xfs_file_sync_writes(file))
> > error = xfs_log_force_inode(ip);
>
> I'd think if you hit -ENOSPC or something after doing a partial alloc to
> a sync inode, you'd still want to flush the changes that were made..?
Persistence behavior on error is always undefined. And that's also
what the current code does, as it jumps past the log force from all
error exits.
next prev parent reply other threads:[~2024-08-21 12:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-21 6:30 sort out the fallocate mode mess Christoph Hellwig
2024-08-21 6:30 ` [PATCH 1/6] block: remove checks for FALLOC_FL_NO_HIDE_STALE Christoph Hellwig
2024-08-21 6:30 ` [PATCH 2/6] ext4: remove tracing " Christoph Hellwig
2024-08-21 6:30 ` [PATCH 3/6] fs: sort out the fallocate mode vs flag mess Christoph Hellwig
2024-08-21 12:43 ` Brian Foster
2024-08-21 13:14 ` Christoph Hellwig
2024-08-21 6:30 ` [PATCH 4/6] xfs: call xfs_flush_unmap_range from xfs_free_file_space Christoph Hellwig
2024-08-21 6:30 ` [PATCH 5/6] xfs: move the xfs_is_always_cow_inode check into xfs_alloc_file_space Christoph Hellwig
2024-08-21 6:30 ` [PATCH 6/6] xfs: refactor xfs_file_fallocate Christoph Hellwig
2024-08-21 12:44 ` Brian Foster
2024-08-21 12:57 ` Christoph Hellwig [this message]
2024-08-21 13:09 ` Brian Foster
2024-08-21 16:11 ` sort out the fallocate mode mess Darrick J. Wong
-- strict thread matches above, loose matches on Subject: below --
2024-08-27 6:50 sort out the fallocate mode mess v2 Christoph Hellwig
2024-08-27 6:50 ` [PATCH 6/6] xfs: refactor xfs_file_fallocate Christoph Hellwig
2024-08-27 16:07 ` Darrick J. Wong
2024-08-28 4:07 ` Christoph Hellwig
2024-08-29 3:11 ` Dave Chinner
2024-08-29 3:56 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240821125756.GA21319@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=bfoster@redhat.com \
--cc=brauner@kernel.org \
--cc=chandan.babu@oracle.com \
--cc=djwong@kernel.org \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).