linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] fs: s/__u32/u32/ for s_fsnotify_mask
@ 2024-08-22  9:30 Christian Brauner
  2024-08-28 10:59 ` Jan Kara
  0 siblings, 1 reply; 2+ messages in thread
From: Christian Brauner @ 2024-08-22  9:30 UTC (permalink / raw)
  To: Amir Goldstein, linux-fsdevel; +Cc: Christian Brauner, Jeff Layton, Jan Kara

The underscore variants are for uapi whereas the non-underscore variants
are for in-kernel consumers.

Signed-off-by: Christian Brauner <brauner@kernel.org>
---
 include/linux/fs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/fs.h b/include/linux/fs.h
index 23e7d46b818a..7eb4f706d59f 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -1273,7 +1273,7 @@ struct super_block {
 	time64_t		   s_time_min;
 	time64_t		   s_time_max;
 #ifdef CONFIG_FSNOTIFY
-	__u32			s_fsnotify_mask;
+	u32			s_fsnotify_mask;
 	struct fsnotify_sb_info	*s_fsnotify_info;
 #endif
 
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] fs: s/__u32/u32/ for s_fsnotify_mask
  2024-08-22  9:30 [PATCH] fs: s/__u32/u32/ for s_fsnotify_mask Christian Brauner
@ 2024-08-28 10:59 ` Jan Kara
  0 siblings, 0 replies; 2+ messages in thread
From: Jan Kara @ 2024-08-28 10:59 UTC (permalink / raw)
  To: Christian Brauner; +Cc: Amir Goldstein, linux-fsdevel, Jeff Layton, Jan Kara

On Thu 22-08-24 11:30:58, Christian Brauner wrote:
> The underscore variants are for uapi whereas the non-underscore variants
> are for in-kernel consumers.
> 
> Signed-off-by: Christian Brauner <brauner@kernel.org>

I didn't know this :). Sure. Feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
>  include/linux/fs.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/fs.h b/include/linux/fs.h
> index 23e7d46b818a..7eb4f706d59f 100644
> --- a/include/linux/fs.h
> +++ b/include/linux/fs.h
> @@ -1273,7 +1273,7 @@ struct super_block {
>  	time64_t		   s_time_min;
>  	time64_t		   s_time_max;
>  #ifdef CONFIG_FSNOTIFY
> -	__u32			s_fsnotify_mask;
> +	u32			s_fsnotify_mask;
>  	struct fsnotify_sb_info	*s_fsnotify_info;
>  #endif
>  
> -- 
> 2.43.0
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-08-28 10:59 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-22  9:30 [PATCH] fs: s/__u32/u32/ for s_fsnotify_mask Christian Brauner
2024-08-28 10:59 ` Jan Kara

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).