From: Al Viro <viro@zeniv.linux.org.uk>
To: Felix Kuehling <felix.kuehling@amd.com>
Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/4] amdgpu: fix a race in kfd_mem_export_dmabuf()
Date: Thu, 22 Aug 2024 01:29:21 +0100 [thread overview]
Message-ID: <20240822002921.GN504335@ZenIV> (raw)
In-Reply-To: <09a1d083-0960-4de7-ab66-527099076ee4@amd.com>
On Wed, Aug 14, 2024 at 06:15:46PM -0400, Felix Kuehling wrote:
>
> On 2024-08-12 02:59, Al Viro wrote:
> > Using drm_gem_prime_handle_to_fd() to set dmabuf up and insert it into
> > descriptor table, only to have it looked up by file descriptor and
> > remove it from descriptor table is not just too convoluted - it's
> > racy; another thread might have modified the descriptor table while
> > we'd been going through that song and dance.
> >
> > Switch kfd_mem_export_dmabuf() to using drm_gem_prime_handle_to_dmabuf()
> > and leave the descriptor table alone...
> >
> > Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
>
> This patch is
>
> Reviewed-by: Felix Kuehling <felix.kuehling@amd.com>
Umm... So which tree should that series go through?
I can put it through vfs.git, or send a pull request to drm folks, or...
Preferences?
next prev parent reply other threads:[~2024-08-22 0:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-12 6:56 [PATCHES] [drm] file descriptor fixes Al Viro
2024-08-12 6:59 ` [PATCH 1/4] new helper: drm_gem_prime_handle_to_dmabuf() Al Viro
2024-08-12 6:59 ` [PATCH 2/4] amdgpu: fix a race in kfd_mem_export_dmabuf() Al Viro
2024-08-14 22:15 ` Felix Kuehling
2024-08-22 0:29 ` Al Viro [this message]
2024-08-22 18:02 ` Alex Deucher
2024-08-12 6:59 ` [PATCH 3/4] amdkfd CRIU fixes Al Viro
2024-08-12 6:59 ` [PATCH 4/4] amdgpu: get rid of bogus includes of fdtable.h Al Viro
2024-08-22 14:41 ` [PATCH 1/4] new helper: drm_gem_prime_handle_to_dmabuf() Thomas Zimmermann
2024-08-22 15:20 ` Al Viro
2024-08-23 1:57 ` Al Viro
2024-08-23 7:21 ` Thomas Zimmermann
2024-08-23 7:53 ` Al Viro
2024-09-10 16:36 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240822002921.GN504335@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=amd-gfx@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=felix.kuehling@amd.com \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).