From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
Chandan Babu R <chandan.babu@oracle.com>,
Matthew Wilcox <willy@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/5] xfs: move the tagged perag lookup helpers to xfs_icache.c
Date: Thu, 22 Aug 2024 05:47:35 +0200 [thread overview]
Message-ID: <20240822034735.GE32681@lst.de> (raw)
In-Reply-To: <20240821163407.GH865349@frogsfrogsfrogs>
On Wed, Aug 21, 2024 at 09:34:07AM -0700, Darrick J. Wong wrote:
> On Wed, Aug 21, 2024 at 08:38:29AM +0200, Christoph Hellwig wrote:
> > The tagged perag helpers are only used in xfs_icache.c in the kernel code
> > and not at all in xfsprogs. Move them to xfs_icache.c in preparation for
> > switching to an xarray, for which I have no plan to implement the tagged
> > lookup functions for userspace.
>
> I don't particularly like moving these functions to another file, but I
> suppose the icache is the only user of these tags. How hard is it to
> make userspace stubs that assert if anyone ever tries to use it?
It might be easier to just implement them in that case like the underlying
radix tree ones. But given that they are unused I'd feel rather
uncomfortable about it. And more importantly I like to have the
function (only one is left by the end) close to the callers as that makes
reading and understanding the code easier.
next prev parent reply other threads:[~2024-08-22 3:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-21 6:38 convert XFS perag lookup to xarrays v2 Christoph Hellwig
2024-08-21 6:38 ` [PATCH 1/5] xfs: use kfree_rcu_mightsleep to free the perag structures Christoph Hellwig
2024-08-21 16:19 ` Darrick J. Wong
2024-08-22 3:42 ` Christoph Hellwig
2024-08-21 6:38 ` [PATCH 2/5] xfs: move the tagged perag lookup helpers to xfs_icache.c Christoph Hellwig
2024-08-21 16:34 ` Darrick J. Wong
2024-08-22 3:47 ` Christoph Hellwig [this message]
2024-08-28 6:28 ` Christoph Hellwig
2024-08-28 16:10 ` Darrick J. Wong
2024-08-29 3:48 ` Christoph Hellwig
2024-08-21 6:38 ` [PATCH 3/5] xfs: simplify tagged perag iteration Christoph Hellwig
2024-08-21 16:30 ` Darrick J. Wong
2024-08-21 6:38 ` [PATCH 4/5] xfs: convert perag lookup to xarray Christoph Hellwig
2024-08-21 16:28 ` Darrick J. Wong
2024-08-22 3:45 ` Christoph Hellwig
2024-08-27 22:51 ` Dave Chinner
2024-08-21 6:38 ` [PATCH 5/5] xfs: use xas_for_each_marked in xfs_reclaim_inodes_count Christoph Hellwig
2024-08-21 16:22 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240822034735.GE32681@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=chandan.babu@oracle.com \
--cc=djwong@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).