linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Josef Bacik <josef@toxicpanda.com>
To: Christian Brauner <brauner@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	NeilBrown <neilb@suse.de>, Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>, Jeff Layton <jlayton@kernel.org>,
	Jan Kara <jack@suse.cz>,
	linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v3 0/6] inode: turn i_state into u32
Date: Fri, 23 Aug 2024 11:06:13 -0400	[thread overview]
Message-ID: <20240823150613.GA2234629@perftesting> (raw)
In-Reply-To: <20240823-work-i_state-v3-0-5cd5fd207a57@kernel.org>

On Fri, Aug 23, 2024 at 02:47:34PM +0200, Christian Brauner wrote:
> Hey,
> 
> This is v3. I changed to manual barriers as requested and commented
> them.
> 
> ---
> 
> I've recently looked for some free space in struct inode again because
> of some exec kerfuffle we recently had and while my idea didn't turn
> into anything I noticed that we often waste bytes when using wait bit
> operations. So I set out to switch that to another mechanism that would
> allow us to free up bytes. So this is an attempt to turn i_state from
> an unsigned long into an u32 using the individual bytes of i_state as
> addresses for the wait var event mechanism (Thanks to Linus for that idea.).
> 
> This survives LTP, xfstests on various filesystems, and will-it-scale.
> 
> To: Linus Torvalds <torvalds@linux-foundation.org>
> Cc: NeilBrown <neilb@suse.de>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Jeff Layton <jlayton@kernel.org>
> Cc: Jan Kara <jack@suse.cz>
> Cc: Christian Brauner <brauner@kernel.org>
> Cc: linux-fsdevel@vger.kernel.org
> Signed-off-by: Christian Brauner <brauner@kernel.org>

Reviewed-by: Josef Bacik <josef@toxicpanda.com>

Thanks,

Josef

  parent reply	other threads:[~2024-08-23 15:06 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-21 15:47 [PATCH RFC v2 0/6] inode: turn i_state into u32 Christian Brauner
2024-08-21 15:47 ` [PATCH RFC v2 1/6] fs: add i_state helpers Christian Brauner
2024-08-21 22:12   ` NeilBrown
2024-08-21 22:47     ` Linus Torvalds
2024-08-21 23:34     ` Dave Chinner
2024-08-23  0:08       ` NeilBrown
2024-08-22  8:27     ` Christian Brauner
2024-08-22  8:37       ` Linus Torvalds
2024-08-23  0:14       ` NeilBrown
2024-08-23  2:52         ` Linus Torvalds
2024-08-23  3:05           ` Linus Torvalds
2024-08-23  3:44             ` Linus Torvalds
2024-08-23  5:01           ` NeilBrown
2024-08-23 12:47           ` [PATCH v3 0/6] inode: turn i_state into u32 Christian Brauner
2024-08-23 12:47             ` [PATCH v3 1/6] fs: add i_state helpers Christian Brauner
2024-09-05 16:01               ` Jan Kara
2024-08-23 12:47             ` [PATCH v3 2/6] fs: reorder i_state bits Christian Brauner
2024-09-05 16:02               ` Jan Kara
2024-08-23 12:47             ` [PATCH v3 3/6] inode: port __I_SYNC to var event Christian Brauner
2024-09-05 16:02               ` Jan Kara
2024-08-23 12:47             ` [PATCH v3 4/6] inode: port __I_NEW " Christian Brauner
2024-09-06 13:30               ` Jan Kara
2024-08-23 12:47             ` [PATCH v3 5/6] inode: port __I_LRU_ISOLATING " Christian Brauner
2024-09-09  7:35               ` Jan Kara
2024-08-23 12:47             ` [PATCH v3 6/6] inode: make i_state a u32 Christian Brauner
2024-09-09  7:35               ` Jan Kara
2024-08-23 15:06             ` Josef Bacik [this message]
2024-08-21 22:28   ` [PATCH RFC v2 1/6] fs: add i_state helpers Dave Chinner
2024-08-21 22:53     ` Linus Torvalds
2024-08-21 15:47 ` [PATCH RFC v2 2/6] fs: reorder i_state bits Christian Brauner
2024-08-21 15:47 ` [PATCH RFC v2 3/6] writeback: port __I_SYNC to var event Christian Brauner
2024-08-21 15:47 ` [PATCH RFC v2 4/6] inode: port __I_NEW " Christian Brauner
2024-08-23  0:31   ` NeilBrown
2024-08-23  8:20     ` Christian Brauner
2024-08-23 11:07       ` Christian Brauner
2024-08-21 15:47 ` [PATCH RFC v2 5/6] inode: port __I_LRU_ISOLATING " Christian Brauner
2024-08-21 19:41   ` Jeff Layton
2024-08-22  8:53     ` Christian Brauner
2024-08-22  9:48       ` Mateusz Guzik
2024-08-22 11:10         ` Christian Brauner
2024-08-22 12:46           ` Mateusz Guzik
2024-08-23  0:36   ` NeilBrown
2024-08-23  2:24     ` Linus Torvalds
2024-08-23  8:29       ` Christian Brauner
2024-08-21 15:47 ` [PATCH RFC v2 6/6] inode: make i_state a u32 Christian Brauner
2024-08-21 21:03   ` Andreas Dilger
2024-08-22  8:31     ` Christian Brauner
2024-08-21 19:15 ` [PATCH RFC v2 0/6] inode: turn i_state into u32 Josef Bacik
2024-08-21 19:42 ` Jeff Layton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240823150613.GA2234629@perftesting \
    --to=josef@toxicpanda.com \
    --cc=brauner@kernel.org \
    --cc=jack@suse.cz \
    --cc=jlayton@kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=neilb@suse.de \
    --cc=peterz@infradead.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).