From: Christian Brauner <brauner@kernel.org>
To: Yan Zhen <yanzhen@vivo.com>
Cc: viro@zeniv.linux.org.uk, jack@suse.cz,
linux-fsdevel@vger.kernel.org, opensource.kernel@vivo.com
Subject: Re: [PATCH v1] fs: proc: Fix error checking for d_hash_and_lookup()
Date: Mon, 26 Aug 2024 12:39:40 +0200 [thread overview]
Message-ID: <20240826-festland-ungeteilt-a281f70a1afc@brauner> (raw)
In-Reply-To: <20240826090802.2358591-1-yanzhen@vivo.com>
On Mon, Aug 26, 2024 at 05:08:02PM GMT, Yan Zhen wrote:
> The d_hash_and_lookup() function returns either an error pointer or NULL.
>
> It might be more appropriate to check error using IS_ERR_OR_NULL().
>
> Signed-off-by: Yan Zhen <yanzhen@vivo.com>
> ---
I distinctly remember having NAKed a patch like this either earlier this
or last year. Procfs doesn't have a custom d_hash() function so
d_hash_and_lookup() will never return an error pointer afaict.
next prev parent reply other threads:[~2024-08-26 10:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-26 9:08 [PATCH v1] fs: proc: Fix error checking for d_hash_and_lookup() Yan Zhen
2024-08-26 10:39 ` Christian Brauner [this message]
2024-08-26 13:49 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240826-festland-ungeteilt-a281f70a1afc@brauner \
--to=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=opensource.kernel@vivo.com \
--cc=viro@zeniv.linux.org.uk \
--cc=yanzhen@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).