From: Kees Cook <kees@kernel.org>
To: Thorsten Blum <thorsten.blum@toblux.com>
Cc: dsterba@suse.com, gustavoars@kernel.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] affs: Remove unused struct members in affs_root_head
Date: Mon, 26 Aug 2024 13:08:05 -0700 [thread overview]
Message-ID: <202408261307.F7D2AD650@keescook> (raw)
In-Reply-To: <20240826142735.64490-2-thorsten.blum@toblux.com>
On Mon, Aug 26, 2024 at 04:27:36PM +0200, Thorsten Blum wrote:
> Only ptype is actually used. Remove the other struct members.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>
> ---
> fs/affs/amigaffs.h | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/fs/affs/amigaffs.h b/fs/affs/amigaffs.h
> index 1b973a669d23..9b40ae618852 100644
> --- a/fs/affs/amigaffs.h
> +++ b/fs/affs/amigaffs.h
> @@ -49,12 +49,6 @@ struct affs_short_date {
>
> struct affs_root_head {
> __be32 ptype;
> - __be32 spare1;
> - __be32 spare2;
> - __be32 hash_size;
> - __be32 spare3;
> - __be32 checksum;
> - __be32 hashtable[1];
> };
This is removing documentation, in a way. Since I suspect you were
looking at this due to hashtable, maybe just change that to [] and note
that it (and the other fields) aren't used, but they're kept around to
help document the format.
--
Kees Cook
next prev parent reply other threads:[~2024-08-26 20:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-26 14:27 [PATCH] affs: Remove unused struct members in affs_root_head Thorsten Blum
2024-08-26 20:08 ` Kees Cook [this message]
2024-08-26 20:48 ` Thorsten Blum
2024-08-27 12:51 ` Thorsten Blum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202408261307.F7D2AD650@keescook \
--to=kees@kernel.org \
--cc=dsterba@suse.com \
--cc=gustavoars@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thorsten.blum@toblux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).