linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yafang Shao <laoar.shao@gmail.com>
To: akpm@linux-foundation.org
Cc: torvalds@linux-foundation.org, alx@kernel.org,
	justinstitt@google.com, ebiederm@xmission.com,
	alexei.starovoitov@gmail.com, rostedt@goodmis.org,
	catalin.marinas@arm.com, penguin-kernel@i-love.sakura.ne.jp,
	linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
	linux-trace-kernel@vger.kernel.org, audit@vger.kernel.org,
	linux-security-module@vger.kernel.org, selinux@vger.kernel.org,
	bpf@vger.kernel.org, netdev@vger.kernel.org,
	dri-devel@lists.freedesktop.org,
	Yafang Shao <laoar.shao@gmail.com>,
	Quentin Monnet <qmo@kernel.org>
Subject: [PATCH v8 4/8] bpftool: Ensure task comm is always NUL-terminated
Date: Wed, 28 Aug 2024 11:03:17 +0800	[thread overview]
Message-ID: <20240828030321.20688-5-laoar.shao@gmail.com> (raw)
In-Reply-To: <20240828030321.20688-1-laoar.shao@gmail.com>

Let's explicitly ensure the destination string is NUL-terminated. This way,
it won't be affected by changes to the source string.

Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
Reviewed-by: Quentin Monnet <qmo@kernel.org>
---
 tools/bpf/bpftool/pids.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/bpf/bpftool/pids.c b/tools/bpf/bpftool/pids.c
index 9b898571b49e..23f488cf1740 100644
--- a/tools/bpf/bpftool/pids.c
+++ b/tools/bpf/bpftool/pids.c
@@ -54,6 +54,7 @@ static void add_ref(struct hashmap *map, struct pid_iter_entry *e)
 		ref = &refs->refs[refs->ref_cnt];
 		ref->pid = e->pid;
 		memcpy(ref->comm, e->comm, sizeof(ref->comm));
+		ref->comm[sizeof(ref->comm) - 1] = '\0';
 		refs->ref_cnt++;
 
 		return;
@@ -77,6 +78,7 @@ static void add_ref(struct hashmap *map, struct pid_iter_entry *e)
 	ref = &refs->refs[0];
 	ref->pid = e->pid;
 	memcpy(ref->comm, e->comm, sizeof(ref->comm));
+	ref->comm[sizeof(ref->comm) - 1] = '\0';
 	refs->ref_cnt = 1;
 	refs->has_bpf_cookie = e->has_bpf_cookie;
 	refs->bpf_cookie = e->bpf_cookie;
-- 
2.43.5


  parent reply	other threads:[~2024-08-28  3:04 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-28  3:03 [PATCH v8 0/8] Improve the copy of task comm Yafang Shao
2024-08-28  3:03 ` [PATCH v8 1/8] Get rid of __get_task_comm() Yafang Shao
2024-08-28 10:15   ` Alejandro Colomar
2024-08-28 12:57     ` Yafang Shao
2024-08-28 12:58     ` Alejandro Colomar
2024-08-28 13:40       ` Yafang Shao
2024-08-28 13:48         ` Kees Cook
2024-08-28 15:09           ` Alejandro Colomar
2024-08-29  0:17             ` Kees Cook
2024-08-29  0:25               ` Alejandro Colomar
2024-08-28 14:10         ` Alejandro Colomar
2024-08-28 14:03   ` Kees Cook
2024-08-29  6:30     ` Yafang Shao
2024-08-28  3:03 ` [PATCH v8 2/8] auditsc: Replace memcpy() with strscpy() Yafang Shao
2024-09-12 20:59   ` Justin Stitt
2024-08-28  3:03 ` [PATCH v8 3/8] security: Replace memcpy() with get_task_comm() Yafang Shao
2024-08-28  3:03 ` Yafang Shao [this message]
2024-09-12 21:14   ` [PATCH v8 4/8] bpftool: Ensure task comm is always NUL-terminated Justin Stitt
2024-09-13  2:20     ` Yafang Shao
2024-08-28  3:03 ` [PATCH v8 5/8] mm/util: Fix possible race condition in kstrdup() Yafang Shao
2024-08-28  3:03 ` [PATCH v8 6/8] mm/util: Deduplicate code in {kstrdup,kstrndup,kmemdup_nul} Yafang Shao
2024-08-28 10:32   ` Alejandro Colomar
2024-08-28 10:33     ` Alejandro Colomar
2024-08-28 12:58       ` Yafang Shao
2024-08-28  3:03 ` [PATCH v8 7/8] net: Replace strcpy() with strscpy() Yafang Shao
2024-09-12 21:22   ` Justin Stitt
2024-08-28  3:03 ` [PATCH v8 8/8] drm: " Yafang Shao
2024-09-12 21:28   ` Justin Stitt
2024-09-13  2:23     ` Yafang Shao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240828030321.20688-5-laoar.shao@gmail.com \
    --to=laoar.shao@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=alexei.starovoitov@gmail.com \
    --cc=alx@kernel.org \
    --cc=audit@vger.kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=ebiederm@xmission.com \
    --cc=justinstitt@google.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=penguin-kernel@i-love.sakura.ne.jp \
    --cc=qmo@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=selinux@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).