[PATCH v2] writeback: Refine the show_inode_state() macro definition

[PATCH v2] writeback: Refine the show_inode_state() macro definition

[Julian Sun]

Currently, the show_inode_state() macro only prints
part of the state of inode->i_state. Let’s improve it
to display more of its state.

Signed-off-by: Julian Sun <sunjunchao2870@gmail.com>
---
 include/trace/events/writeback.h | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/include/trace/events/writeback.h b/include/trace/events/writeback.h
index 54e353c9f919..a261e86e61fa 100644
--- a/include/trace/events/writeback.h
+++ b/include/trace/events/writeback.h
@@ -20,7 +20,15 @@
 		{I_CLEAR,		"I_CLEAR"},		\
 		{I_SYNC,		"I_SYNC"},		\
 		{I_DIRTY_TIME,		"I_DIRTY_TIME"},	\
-		{I_REFERENCED,		"I_REFERENCED"}		\
+		{I_REFERENCED,		"I_REFERENCED"},	\
+		{I_LINKABLE,		"I_LINKABLE"},		\
+		{I_WB_SWITCH,		"I_WB_SWITCH"},		\
+		{I_OVL_INUSE,		"I_OVL_INUSE"},		\
+		{I_CREATING,		"I_CREATING"},		\
+		{I_DONTCACHE,		"I_DONTCACHE"},		\
+		{I_SYNC_QUEUED,		"I_SYNC_QUEUED"},	\
+		{I_PINNING_NETFS_WB,	"I_PINNING_NETFS_WB"},	\
+		{I_LRU_ISOLATING,	"I_LRU_ISOLATING"}	\
 	)
 
 /* enums need to be exported to user space */
-- 
2.39.2

Re: [PATCH v2] writeback: Refine the show_inode_state() macro definition

[Jan Kara]

On Wed 28-08-24 16:13:59, Julian Sun wrote:
> Currently, the show_inode_state() macro only prints
> part of the state of inode->i_state. Let’s improve it
> to display more of its state.
> 
> Signed-off-by: Julian Sun <sunjunchao2870@gmail.com>

Looks good to me. Feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
>  include/trace/events/writeback.h | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/include/trace/events/writeback.h b/include/trace/events/writeback.h
> index 54e353c9f919..a261e86e61fa 100644
> --- a/include/trace/events/writeback.h
> +++ b/include/trace/events/writeback.h
> @@ -20,7 +20,15 @@
>  		{I_CLEAR,		"I_CLEAR"},		\
>  		{I_SYNC,		"I_SYNC"},		\
>  		{I_DIRTY_TIME,		"I_DIRTY_TIME"},	\
> -		{I_REFERENCED,		"I_REFERENCED"}		\
> +		{I_REFERENCED,		"I_REFERENCED"},	\
> +		{I_LINKABLE,		"I_LINKABLE"},		\
> +		{I_WB_SWITCH,		"I_WB_SWITCH"},		\
> +		{I_OVL_INUSE,		"I_OVL_INUSE"},		\
> +		{I_CREATING,		"I_CREATING"},		\
> +		{I_DONTCACHE,		"I_DONTCACHE"},		\
> +		{I_SYNC_QUEUED,		"I_SYNC_QUEUED"},	\
> +		{I_PINNING_NETFS_WB,	"I_PINNING_NETFS_WB"},	\
> +		{I_LRU_ISOLATING,	"I_LRU_ISOLATING"}	\
>  	)
>  
>  /* enums need to be exported to user space */
> -- 
> 2.39.2
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

Re: [PATCH v2] writeback: Refine the show_inode_state() macro definition

[Christian Brauner]

On Wed, 28 Aug 2024 16:13:59 +0800, Julian Sun wrote:
> Currently, the show_inode_state() macro only prints
> part of the state of inode->i_state. Let’s improve it
> to display more of its state.
> 
> 

Applied to the vfs.misc branch of the vfs/vfs.git tree.
Patches in the vfs.misc branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.misc

[1/1] writeback: Refine the show_inode_state() macro definition
      https://git.kernel.org/vfs/vfs/c/5b07b8fbb89a