linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Josef Bacik <josef@toxicpanda.com>
To: Brian Foster <bfoster@redhat.com>
Cc: linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org,
	djwong@kernel.org, david@fromorbit.com
Subject: Re: [PATCH v2 0/2] iomap: flush dirty cache over unwritten mappings on zero range
Date: Wed, 28 Aug 2024 16:44:14 -0400	[thread overview]
Message-ID: <20240828204414.GB2974106@perftesting> (raw)
In-Reply-To: <20240828181912.41517-1-bfoster@redhat.com>

On Wed, Aug 28, 2024 at 02:19:09PM -0400, Brian Foster wrote:
> Hi all,
> 
> Here's v2 of the iomap zero range flush fixes. No real changes here
> other than a comment update to better explain a subtle corner case. The
> latest version of corresponding test support is posted here [1].
> Thoughts, reviews, flames appreciated.
> 
> Brian
> 

Took me a second to grok what you were doing in the second patch, mostly because
I'm not as familiar with the iomap code, so with that caveat you can add

Reviewed-by: Josef Bacik <josef@toxicpanda.com>

Thanks,

Josef

      parent reply	other threads:[~2024-08-28 20:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-28 18:19 [PATCH v2 0/2] iomap: flush dirty cache over unwritten mappings on zero range Brian Foster
2024-08-28 18:19 ` [PATCH v2 1/2] iomap: fix handling of dirty folios over unwritten extents Brian Foster
2024-08-28 22:22   ` Darrick J. Wong
2024-08-29  5:43     ` Christoph Hellwig
2024-08-28 18:19 ` [PATCH v2 2/2] iomap: make zero range flush conditional on unwritten mappings Brian Foster
2024-08-28 22:44   ` Darrick J. Wong
2024-08-29  0:26     ` Dave Chinner
2024-08-29 15:04       ` Brian Foster
2024-08-29 15:03     ` Brian Foster
2024-08-29 17:29       ` Brian Foster
2024-08-29 21:34       ` Darrick J. Wong
2024-08-30 11:58         ` Brian Foster
2024-08-28 20:44 ` Josef Bacik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240828204414.GB2974106@perftesting \
    --to=josef@toxicpanda.com \
    --cc=bfoster@redhat.com \
    --cc=david@fromorbit.com \
    --cc=djwong@kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).