linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christian Brauner <brauner@kernel.org>
To: Vlastimil Babka <vbabka@suse.cz>, Jens Axboe <axboe@kernel.dk>,
	 Jann Horn <jannh@google.com>,
	 Linus Torvalds <torvalds@linux-foundation.org>,
	 Mike Rapoport <rppt@kernel.org>
Cc: Kees Cook <kees@kernel.org>, Christoph Lameter <cl@linux.com>,
	 Pekka Enberg <penberg@kernel.org>,
	David Rientjes <rientjes@google.com>,
	 Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	 Andrew Morton <akpm@linux-foundation.org>,
	 Roman Gushchin <roman.gushchin@linux.dev>,
	 Hyeonggon Yoo <42.hyeyoo@gmail.com>,
	linux-mm@kvack.org,  linux-fsdevel@vger.kernel.org,
	Christian Brauner <brauner@kernel.org>
Subject: [PATCH v3 05/17] slab: port kmem_cache_create_usercopy() to struct kmem_cache_args
Date: Wed, 04 Sep 2024 12:21:10 +0200	[thread overview]
Message-ID: <20240904-work-kmem_cache_args-v3-5-05db2179a8c2@kernel.org> (raw)
In-Reply-To: <20240904-work-kmem_cache_args-v3-0-05db2179a8c2@kernel.org>

Port kmem_cache_create_usercopy() to struct kmem_cache_args and remove
the now unused do_kmem_cache_create_usercopy() helper.

Reviewed-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
Reviewed-by: Vlastimil Babka <vbabka@suse.cz>
Signed-off-by: Christian Brauner <brauner@kernel.org>
---
 mm/slab_common.c | 30 ++++++++----------------------
 1 file changed, 8 insertions(+), 22 deletions(-)

diff --git a/mm/slab_common.c b/mm/slab_common.c
index da62ed30f95d..16c36a946135 100644
--- a/mm/slab_common.c
+++ b/mm/slab_common.c
@@ -351,26 +351,6 @@ struct kmem_cache *__kmem_cache_create_args(const char *name,
 }
 EXPORT_SYMBOL(__kmem_cache_create_args);
 
-static struct kmem_cache *
-do_kmem_cache_create_usercopy(const char *name,
-                 unsigned int size, unsigned int freeptr_offset,
-                 unsigned int align, slab_flags_t flags,
-                 unsigned int useroffset, unsigned int usersize,
-                 void (*ctor)(void *))
-{
-	struct kmem_cache_args kmem_args = {
-		.align			= align,
-		.use_freeptr_offset	= freeptr_offset != UINT_MAX,
-		.freeptr_offset		= freeptr_offset,
-		.useroffset		= useroffset,
-		.usersize		= usersize,
-		.ctor			= ctor,
-	};
-
-	return __kmem_cache_create_args(name, size, &kmem_args, flags);
-}
-
-
 /**
  * kmem_cache_create_usercopy - Create a cache with a region suitable
  * for copying to userspace
@@ -405,8 +385,14 @@ kmem_cache_create_usercopy(const char *name, unsigned int size,
 			   unsigned int useroffset, unsigned int usersize,
 			   void (*ctor)(void *))
 {
-	return do_kmem_cache_create_usercopy(name, size, UINT_MAX, align, flags,
-					     useroffset, usersize, ctor);
+	struct kmem_cache_args kmem_args = {
+		.align		= align,
+		.ctor		= ctor,
+		.useroffset	= useroffset,
+		.usersize	= usersize,
+	};
+
+	return __kmem_cache_create_args(name, size, &kmem_args, flags);
 }
 EXPORT_SYMBOL(kmem_cache_create_usercopy);
 

-- 
2.45.2


  parent reply	other threads:[~2024-09-04 10:22 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-04 10:21 [PATCH v3 00/17] slab: add struct kmem_cache_args Christian Brauner
2024-09-04 10:21 ` [PATCH v3 01/17] slab: s/__kmem_cache_create/do_kmem_cache_create/g Christian Brauner
2024-09-04 10:21 ` [PATCH v3 02/17] slab: add struct kmem_cache_args Christian Brauner
2024-09-04 10:21 ` [PATCH v3 03/17] slab: port kmem_cache_create() to " Christian Brauner
2024-09-04 10:21 ` [PATCH v3 04/17] slab: port kmem_cache_create_rcu() " Christian Brauner
2024-09-04 10:21 ` Christian Brauner [this message]
2024-09-04 10:21 ` [PATCH v3 06/17] slab: pass struct kmem_cache_args to create_cache() Christian Brauner
2024-09-04 10:21 ` [PATCH v3 07/17] slab: pull kmem_cache_open() into do_kmem_cache_create() Christian Brauner
2024-09-04 10:21 ` [PATCH v3 08/17] slab: pass struct kmem_cache_args to do_kmem_cache_create() Christian Brauner
2024-09-04 10:21 ` [PATCH v3 09/17] slab: remove rcu_freeptr_offset from struct kmem_cache Christian Brauner
2024-09-04 10:21 ` [PATCH v3 10/17] slab: port KMEM_CACHE() to struct kmem_cache_args Christian Brauner
2024-09-04 10:21 ` [PATCH v3 11/17] slab: port KMEM_CACHE_USERCOPY() " Christian Brauner
2024-09-04 10:21 ` [PATCH v3 12/17] slab: create kmem_cache_create() compatibility layer Christian Brauner
2024-09-04 10:21 ` [PATCH v3 13/17] file: port to struct kmem_cache_args Christian Brauner
2024-09-04 10:21 ` [PATCH v3 14/17] slab: remove kmem_cache_create_rcu() Christian Brauner
2024-09-04 10:21 ` [PATCH v3 15/17] slab: make kmem_cache_create_usercopy() static inline Christian Brauner
2024-09-04 10:21 ` [PATCH v3 16/17] slab: make __kmem_cache_create() " Christian Brauner
2024-09-04 10:21 ` [PATCH v3 17/17] io_uring: port to struct kmem_cache_args Christian Brauner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240904-work-kmem_cache_args-v3-5-05db2179a8c2@kernel.org \
    --to=brauner@kernel.org \
    --cc=42.hyeyoo@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=axboe@kernel.dk \
    --cc=cl@linux.com \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=jannh@google.com \
    --cc=kees@kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=penberg@kernel.org \
    --cc=rientjes@google.com \
    --cc=roman.gushchin@linux.dev \
    --cc=rppt@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).