linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christian Brauner <brauner@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Christian Brauner <brauner@kernel.org>,
	linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	Chandan Babu R <chandan.babu@oracle.com>,
	"Darrick J. Wong" <djwong@kernel.org>
Subject: Re: (subset) fix stale delalloc punching for COW I/O v2
Date: Tue, 10 Sep 2024 11:22:20 +0200	[thread overview]
Message-ID: <20240910-parallel-abtropfen-b166de2c9058@brauner> (raw)
In-Reply-To: <20240910043949.3481298-1-hch@lst.de>

On Tue, 10 Sep 2024 07:39:02 +0300, Christoph Hellwig wrote:
> this is another fallout from the zoned XFS work, which stresses the XFS
> COW I/O path very heavily.  It affects normal I/O to reflinked files as
> well, but is very hard to hit there.
> 
> The main problem here is that we only punch out delalloc reservations
> from the data fork, but COW I/O places delalloc extents into the COW
> fork, which means that it won't get punched out forshort writes.
> 
> [...]

Christoph, could you double-check that things look good to you? I had to
resolve a minor merge conflict.

---

Applied to the vfs.blocksize branch of the vfs/vfs.git tree.
Patches in the vfs.blocksize branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.blocksize

[01/12] iomap: handle a post-direct I/O invalidate race in iomap_write_delalloc_release
        https://git.kernel.org/vfs/vfs/c/7a9d43eace88
[02/12] iomap: improve shared block detection in iomap_unshare_iter
        https://git.kernel.org/vfs/vfs/c/b53fdb215d13
[03/12] iomap: pass flags to iomap_file_buffered_write_punch_delalloc
        https://git.kernel.org/vfs/vfs/c/11596dc3dfae
[04/12] iomap: pass the iomap to the punch callback
        https://git.kernel.org/vfs/vfs/c/492f53758fad
[05/12] iomap: remove the iomap_file_buffered_write_punch_delalloc return value
        https://git.kernel.org/vfs/vfs/c/4bceb9ba05ac

  parent reply	other threads:[~2024-09-10  9:22 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-10  4:39 fix stale delalloc punching for COW I/O v2 Christoph Hellwig
2024-09-10  4:39 ` [PATCH 01/12] iomap: handle a post-direct I/O invalidate race in iomap_write_delalloc_release Christoph Hellwig
2024-09-10  4:39 ` [PATCH 02/12] iomap: improve shared block detection in iomap_unshare_iter Christoph Hellwig
2024-09-10  4:39 ` [PATCH 03/12] iomap: pass flags to iomap_file_buffered_write_punch_delalloc Christoph Hellwig
2024-09-10  4:39 ` [PATCH 04/12] iomap: pass the iomap to the punch callback Christoph Hellwig
2024-09-10  4:39 ` [PATCH 05/12] iomap: remove the iomap_file_buffered_write_punch_delalloc return value Christoph Hellwig
2024-09-10  4:39 ` [PATCH 06/12] xfs: factor out a xfs_file_write_zero_eof helper Christoph Hellwig
2024-09-17 21:14   ` Darrick J. Wong
2024-09-18  5:09     ` Christoph Hellwig
2024-09-18 15:30       ` Darrick J. Wong
2024-09-20  0:25       ` Dave Chinner
2024-09-20 11:31         ` Christoph Hellwig
2024-09-10  4:39 ` [PATCH 07/12] xfs: take XFS_MMAPLOCK_EXCL xfs_file_write_zero_eof Christoph Hellwig
2024-09-17 21:24   ` Darrick J. Wong
2024-09-18  5:10     ` Christoph Hellwig
2024-09-10  4:39 ` [PATCH 08/12] iomap: zeroing already holds invalidate_lock Christoph Hellwig
2024-09-17 21:29   ` Darrick J. Wong
2024-09-18  5:15     ` Christoph Hellwig
2024-09-18 15:32       ` Darrick J. Wong
2024-09-20  0:42       ` Dave Chinner
2024-09-10  4:39 ` [PATCH 09/12] xfs: support the COW fork in xfs_bmap_punch_delalloc_range Christoph Hellwig
2024-09-10  4:39 ` [PATCH 10/12] xfs: share more code in xfs_buffered_write_iomap_begin Christoph Hellwig
2024-09-10  4:39 ` [PATCH 11/12] xfs: set IOMAP_F_SHARED for all COW fork allocations Christoph Hellwig
2024-09-10  4:39 ` [PATCH 12/12] xfs: punch delalloc extents from the COW fork for COW writes Christoph Hellwig
2024-09-10  9:21 ` fix stale delalloc punching for COW I/O v2 Christian Brauner
2024-09-10 15:17   ` Christoph Hellwig
2024-09-10  9:22 ` Christian Brauner [this message]
2024-09-10 15:17   ` (subset) " Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240910-parallel-abtropfen-b166de2c9058@brauner \
    --to=brauner@kernel.org \
    --cc=chandan.babu@oracle.com \
    --cc=djwong@kernel.org \
    --cc=hch@lst.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).