linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] unicode: change the reference of database file
@ 2024-09-12  3:19 ganjie
  2024-09-12  6:57 ` Christoph Hellwig
  2024-09-13 15:26 ` Gabriel Krisman Bertazi
  0 siblings, 2 replies; 4+ messages in thread
From: ganjie @ 2024-09-12  3:19 UTC (permalink / raw)
  To: krisman, linux-fsdevel, hch; +Cc: linux-kernel, guoxuenan, guoxuenan, ganjie182

From: Gan Jie <ganjie182@gmail.com>

Commit 2b3d04787012 ("unicode: Add utf8-data module") changed
the database file from 'utf8data.h' to 'utf8data.c' to build
separate module, but it seems forgot to update README.utf8data
, which may causes confusion. Update the README.utf8data and
the default 'UTF8_NAME' in 'mkutf8data.c'.

Signed-off-by: Gan Jie <ganjie182@gmail.com>
---
 fs/unicode/README.utf8data | 8 ++++----
 fs/unicode/mkutf8data.c    | 2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/fs/unicode/README.utf8data b/fs/unicode/README.utf8data
index c73786807d3b..f75567e28138 100644
--- a/fs/unicode/README.utf8data
+++ b/fs/unicode/README.utf8data
@@ -1,4 +1,4 @@
-The utf8data.h file in this directory is generated from the Unicode
+The utf8data.c file in this directory is generated from the Unicode
 Character Database for version 12.1.0 of the Unicode standard.
 
 The full set of files can be found here:
@@ -45,13 +45,13 @@ Then, build under fs/unicode/ with REGENERATE_UTF8DATA=1:
 
 	make REGENERATE_UTF8DATA=1 fs/unicode/
 
-After sanity checking the newly generated utf8data.h file (the
+After sanity checking the newly generated utf8data.c file (the
 version generated from the 12.1.0 UCD should be 4,109 lines long, and
 have a total size of 324k) and/or comparing it with the older version
-of utf8data.h_shipped, rename it to utf8data.h_shipped.
+of utf8data.c_shipped, rename it to utf8data.c_shipped.
 
 If you are a kernel developer updating to a newer version of the
 Unicode Character Database, please update this README.utf8data file
 with the version of the UCD that was used, the md5sum and sha1sums of
-the *.txt files, before checking in the new versions of the utf8data.h
+the *.txt files, before checking in the new versions of the utf8data.c
 and README.utf8data files.
diff --git a/fs/unicode/mkutf8data.c b/fs/unicode/mkutf8data.c
index 57e0e290ce6f..401f5d3aeb0c 100644
--- a/fs/unicode/mkutf8data.c
+++ b/fs/unicode/mkutf8data.c
@@ -36,7 +36,7 @@
 #define FOLD_NAME	"CaseFolding.txt"
 #define NORM_NAME	"NormalizationCorrections.txt"
 #define TEST_NAME	"NormalizationTest.txt"
-#define UTF8_NAME	"utf8data.h"
+#define UTF8_NAME	"utf8data.c"
 
 const char	*age_name  = AGE_NAME;
 const char	*ccc_name  = CCC_NAME;
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] unicode: change the reference of database file
  2024-09-12  3:19 [PATCH v2] unicode: change the reference of database file ganjie
@ 2024-09-12  6:57 ` Christoph Hellwig
  2024-09-12  9:03   ` 干捷
  2024-09-13 15:26 ` Gabriel Krisman Bertazi
  1 sibling, 1 reply; 4+ messages in thread
From: Christoph Hellwig @ 2024-09-12  6:57 UTC (permalink / raw)
  To: ganjie; +Cc: krisman, linux-fsdevel, hch, linux-kernel, guoxuenan, guoxuenan

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] unicode: change the reference of database file
  2024-09-12  6:57 ` Christoph Hellwig
@ 2024-09-12  9:03   ` 干捷
  0 siblings, 0 replies; 4+ messages in thread
From: 干捷 @ 2024-09-12  9:03 UTC (permalink / raw)
  To: Christoph Hellwig
  Cc: krisman, krisman, linux-fsdevel, linux-kernel, guoxuenan,
	guoxuenan, 干捷

Thanks!


Christoph Hellwig <hch@lst.de> 于2024年9月12日周四 14:57写道:
>
> Looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] unicode: change the reference of database file
  2024-09-12  3:19 [PATCH v2] unicode: change the reference of database file ganjie
  2024-09-12  6:57 ` Christoph Hellwig
@ 2024-09-13 15:26 ` Gabriel Krisman Bertazi
  1 sibling, 0 replies; 4+ messages in thread
From: Gabriel Krisman Bertazi @ 2024-09-13 15:26 UTC (permalink / raw)
  To: ganjie; +Cc: krisman, linux-fsdevel, hch, linux-kernel, guoxuenan, guoxuenan

ganjie <ganjie182@gmail.com> writes:

> From: Gan Jie <ganjie182@gmail.com>
>
> Commit 2b3d04787012 ("unicode: Add utf8-data module") changed
> the database file from 'utf8data.h' to 'utf8data.c' to build
> separate module, but it seems forgot to update README.utf8data
> , which may causes confusion. Update the README.utf8data and
> the default 'UTF8_NAME' in 'mkutf8data.c'.
>
> Signed-off-by: Gan Jie <ganjie182@gmail.com>

Applied. thank you!

-- 
Gabriel Krisman Bertazi

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-09-13 15:26 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-12  3:19 [PATCH v2] unicode: change the reference of database file ganjie
2024-09-12  6:57 ` Christoph Hellwig
2024-09-12  9:03   ` 干捷
2024-09-13 15:26 ` Gabriel Krisman Bertazi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).