Linux filesystem development
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	Abaci Robot <abaci@linux.alibaba.com>,
	mhocko@suse.cz
Subject: Re: [PATCH -next] fs/inode: Modify mismatched function name
Date: Fri, 13 Sep 2024 12:29:35 +0200	[thread overview]
Message-ID: <20240913102935.maz3vf42jkmcvfcn@quack3> (raw)
In-Reply-To: <20240913011004.128859-1-jiapeng.chong@linux.alibaba.com>

On Fri 13-09-24 09:10:04, Jiapeng Chong wrote:
> No functional modification involved.
> 
> fs/inode.c:242: warning: expecting prototype for inode_init_always(). Prototype was for inode_init_always_gfp() instead.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=10845
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

I think this is a fallout from Michal's patch [1] which will be respinned
anyway AFAIU. Michal, can you please fixup the kernel doc when sending new
version of the patch? Thanks!

								Honza

[1] https://lore.kernel.org/all/20240827061543.1235703-1-mhocko@kernel.org/

> ---
>  fs/inode.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/inode.c b/fs/inode.c
> index c391365cdfa7..6763900a7a87 100644
> --- a/fs/inode.c
> +++ b/fs/inode.c
> @@ -229,7 +229,7 @@ static int no_open(struct inode *inode, struct file *file)
>  }
>  
>  /**
> - * inode_init_always - perform inode structure initialisation
> + * inode_init_always_gfp - perform inode structure initialisation
>   * @sb: superblock inode belongs to
>   * @inode: inode to initialise
>   * @gfp: allocation flags
> -- 
> 2.32.0.3.g01195cf9f
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

  reply	other threads:[~2024-09-13 10:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-13  1:10 [PATCH -next] fs/inode: Modify mismatched function name Jiapeng Chong
2024-09-13 10:29 ` Jan Kara [this message]
2024-09-13 11:32   ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240913102935.maz3vf42jkmcvfcn@quack3 \
    --to=jack@suse.cz \
    --cc=abaci@linux.alibaba.com \
    --cc=brauner@kernel.org \
    --cc=jiapeng.chong@linux.alibaba.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhocko@suse.cz \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox