From: Al Viro <viro@zeniv.linux.org.uk>
To: Daniel Yang <danielyangkang@gmail.com>
Cc: Namjae Jeon <linkinjeon@kernel.org>,
Sungjong Seo <sj1557.seo@samsung.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
syzbot+e1c69cadec0f1a078e3d@syzkaller.appspotmail.com
Subject: Re: [PATCH] fs/exfat: resolve memory leak from exfat_create_upcase_table()
Date: Sun, 15 Sep 2024 08:26:04 +0100 [thread overview]
Message-ID: <20240915072604.GG2825852@ZenIV> (raw)
In-Reply-To: <20240915072336.GF2825852@ZenIV>
On Sun, Sep 15, 2024 at 08:23:36AM +0100, Al Viro wrote:
> IMO it would be less brittle that way. And commit message needs
> the explanation of the leak mechanism - a link to reporter is
> nice, but it doesn't explain what's going on.
Actually, nevermind the part about commit message - what you have
there is OK. I still think that the call would be better off
in exfat_create_upcase_table(), though - less brittle that way.
prev parent reply other threads:[~2024-09-15 7:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-15 6:44 [PATCH] fs/exfat: resolve memory leak from exfat_create_upcase_table() Daniel Yang
2024-09-15 7:05 ` Al Viro
2024-09-15 7:23 ` Al Viro
2024-09-15 7:26 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240915072604.GG2825852@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=danielyangkang@gmail.com \
--cc=linkinjeon@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sj1557.seo@samsung.com \
--cc=syzbot+e1c69cadec0f1a078e3d@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).