From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [62.89.141.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4036CDDCD; Sun, 15 Sep 2024 07:26:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=62.89.141.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726385169; cv=none; b=P6xklHzDlEegrBG4FBfEVeKoLPYSvdJoGAqem2OspcX4KGk8y8SKyl3pFms3Vg+MEgFnkJe3BOSINg7FXjEmmrJ2PdblqZ/AD7+i+jsrV70T+P1ny5ATVzXBHK1voTgXdF1owGfuLgS39kvpwJ7Iq7DmIEgBuY1uQw1MNY2K7aA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726385169; c=relaxed/simple; bh=4TTkIXqOwXjt3QIuhVO2i3CgfOgMOcIIz3DdvbdShDY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=V1zHT9Yfx6KtdtVLj8oamMBMOo59hagTEbYQetBOu46MVnK2pBpzKBdBna0qcK44lE70PzFjZv2eX+4ILPpy7KdkghqQpTky9toNpjJFRNCmbX0lTFCR+RMSxAnwQhYYJdqddu17JSMex+a70CnPiCHtMvgkKXv2dpQsmxcts+c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=zeniv.linux.org.uk; spf=none smtp.mailfrom=ftp.linux.org.uk; dkim=pass (2048-bit key) header.d=linux.org.uk header.i=@linux.org.uk header.b=YQYyDrH7; arc=none smtp.client-ip=62.89.141.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=zeniv.linux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=ftp.linux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linux.org.uk header.i=@linux.org.uk header.b="YQYyDrH7" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=hw9NdiIoFZEcIKCUQMz5Zk/QZV6yToYX+0ixrS3Dvqk=; b=YQYyDrH7DSsODvUG4D1L1rMKtO 1oK49a/IRcWj5j3nGCCeHWwmFIWyVg9kqfTpyejINrKVwWIJDW3MkLeduz16bkDkJZPX8Hw8+W2rd 2Dur7r4Eg/3QAW9fEQt6C4AIwmYRJimYNQMJUURClk5xKVAOozXx2/oyO0a3sOV2YRENR05N1mRZj 8UWIFJKPU/0mSoa/LKTbQ+/IjquCEtrN+m7FeQhEtBJQGrFZtJtlDdrKlqc0x2H+f5Pv8FTGkMAbg /j37th+PKtTFzgTtTicTkA5YqP0ITkR1p0XS6Vcl03hn0rXWHhRrfTjp7wWdPjUgH1bV6SPW/tFZL hMAPqYsg==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.98 #2 (Red Hat Linux)) id 1spje0-0000000Ccj8-344Q; Sun, 15 Sep 2024 07:26:04 +0000 Date: Sun, 15 Sep 2024 08:26:04 +0100 From: Al Viro To: Daniel Yang Cc: Namjae Jeon , Sungjong Seo , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, syzbot+e1c69cadec0f1a078e3d@syzkaller.appspotmail.com Subject: Re: [PATCH] fs/exfat: resolve memory leak from exfat_create_upcase_table() Message-ID: <20240915072604.GG2825852@ZenIV> References: <20240915064404.221474-1-danielyangkang@gmail.com> <20240915070546.GE2825852@ZenIV> <20240915072336.GF2825852@ZenIV> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240915072336.GF2825852@ZenIV> Sender: Al Viro On Sun, Sep 15, 2024 at 08:23:36AM +0100, Al Viro wrote: > IMO it would be less brittle that way. And commit message needs > the explanation of the leak mechanism - a link to reporter is > nice, but it doesn't explain what's going on. Actually, nevermind the part about commit message - what you have there is OK. I still think that the call would be better off in exfat_create_upcase_table(), though - less brittle that way.