linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alice Ryhl <aliceryhl@google.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Arnd Bergmann <arnd@arndb.de>,  Miguel Ojeda <ojeda@kernel.org>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	 Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>
Cc: "Boqun Feng" <boqun.feng@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <benno.lossin@proton.me>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Trevor Gross" <tmgross@umich.edu>,
	rust-for-linux@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org, "Alice Ryhl" <aliceryhl@google.com>
Subject: [PATCH v2 1/2] rust: types: add Opaque::try_ffi_init
Date: Tue, 01 Oct 2024 08:22:21 +0000	[thread overview]
Message-ID: <20241001-b4-miscdevice-v2-1-330d760041fa@google.com> (raw)
In-Reply-To: <20241001-b4-miscdevice-v2-0-330d760041fa@google.com>

This will be used by the miscdevice abstractions, as the C function
`misc_register` is fallible.

Signed-off-by: Alice Ryhl <aliceryhl@google.com>
---
 rust/kernel/types.rs | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/rust/kernel/types.rs b/rust/kernel/types.rs
index 9e7ca066355c..070d03152937 100644
--- a/rust/kernel/types.rs
+++ b/rust/kernel/types.rs
@@ -299,6 +299,22 @@ pub fn ffi_init(init_func: impl FnOnce(*mut T)) -> impl PinInit<Self> {
         }
     }
 
+    /// Creates a fallible pin-initializer from the given initializer closure.
+    ///
+    /// The returned initializer calls the given closure with the pointer to the inner `T` of this
+    /// `Opaque`. Since this memory is uninitialized, the closure is not allowed to read from it.
+    ///
+    /// This function is safe, because the `T` inside of an `Opaque` is allowed to be
+    /// uninitialized. Additionally, access to the inner `T` requires `unsafe`, so the caller needs
+    /// to verify at that point that the inner value is valid.
+    pub fn try_ffi_init<E>(
+        init_func: impl FnOnce(*mut T) -> Result<(), E>,
+    ) -> impl PinInit<Self, E> {
+        // SAFETY: We contain a `MaybeUninit`, so it is OK for the `init_func` to not fully
+        // initialize the `T`.
+        unsafe { init::pin_init_from_closure::<_, E>(move |slot| init_func(Self::raw_get(slot))) }
+    }
+
     /// Returns a raw pointer to the opaque data.
     pub const fn get(&self) -> *mut T {
         UnsafeCell::get(&self.value).cast::<T>()

-- 
2.46.1.824.gd892dcdcdd-goog


  reply	other threads:[~2024-10-01  8:22 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-01  8:22 [PATCH v2 0/2] Miscdevices in Rust Alice Ryhl
2024-10-01  8:22 ` Alice Ryhl [this message]
2024-10-01  8:46   ` [PATCH v2 1/2] rust: types: add Opaque::try_ffi_init Benno Lossin
2024-10-25  4:10   ` Trevor Gross
2024-10-25  7:57     ` Alice Ryhl
2024-10-01  8:22 ` [PATCH v2 2/2] rust: miscdevice: add base miscdevice abstraction Alice Ryhl
2024-10-01  8:53   ` Dirk Behme
2024-10-01  9:13     ` Alice Ryhl
2024-10-01 11:28   ` Alice Ryhl
2024-10-02 12:48   ` Arnd Bergmann
2024-10-02 12:58     ` Alice Ryhl
2024-10-02 13:24       ` Arnd Bergmann
2024-10-02 13:31         ` Alice Ryhl
2024-10-02 13:57           ` Arnd Bergmann
2024-10-02 14:23             ` Alice Ryhl
2024-10-02 15:31               ` Arnd Bergmann
2024-10-02 13:24     ` Christian Brauner
2024-10-02 13:36       ` Alice Ryhl
2024-10-02 14:23         ` Christian Brauner
2024-10-02 15:45           ` Arnd Bergmann
2024-10-02 16:04             ` Greg Kroah-Hartman
2024-10-02 20:08               ` Arnd Bergmann
2024-10-03  8:19               ` Christian Brauner
2024-10-03  8:09             ` Christian Brauner
2024-10-02 13:31   ` Christian Brauner
2024-10-02 14:06   ` Christian Brauner
2024-10-02 14:24     ` Alice Ryhl
2024-10-03  8:33       ` Christian Brauner
2024-10-21 10:34   ` Miguel Ojeda
2024-10-22 13:15     ` Alice Ryhl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241001-b4-miscdevice-v2-1-330d760041fa@google.com \
    --to=aliceryhl@google.com \
    --cc=a.hindborg@kernel.org \
    --cc=arnd@arndb.de \
    --cc=benno.lossin@proton.me \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=brauner@kernel.org \
    --cc=gary@garyguo.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tmgross@umich.edu \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).