* [PATCH] drm/panthor: Add FOP_UNSIGNED_OFFSET to fop_flags
@ 2024-09-20 10:28 Liviu Dudau
2024-09-20 12:00 ` Boris Brezillon
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: Liviu Dudau @ 2024-09-20 10:28 UTC (permalink / raw)
To: Boris Brezillon
Cc: Steven Price, David Airlie, Simona Vetter, Christian Brauner,
dri-devel, Al Viro, linux-fsdevel
Since 641bb4394f40 ("fs: move FMODE_UNSIGNED_OFFSET to fop_flags")
the FMODE_UNSIGNED_OFFSET flag has been moved to fop_flags and renamed,
but the patch failed to make the changes for the panthor driver.
When user space opens the render node the WARN() added by the patch
gets triggered.
Fixes: 641bb4394f40 ("fs: move FMODE_UNSIGNED_OFFSET to fop_flags")
Cc: Christian Brauner <brauner@kernel.org>
Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>
---
drivers/gpu/drm/panthor/panthor_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/panthor/panthor_drv.c b/drivers/gpu/drm/panthor/panthor_drv.c
index 34182f67136c1..c520f156e2d73 100644
--- a/drivers/gpu/drm/panthor/panthor_drv.c
+++ b/drivers/gpu/drm/panthor/panthor_drv.c
@@ -1383,6 +1383,7 @@ static const struct file_operations panthor_drm_driver_fops = {
.read = drm_read,
.llseek = noop_llseek,
.mmap = panthor_mmap,
+ .fop_flags = FOP_UNSIGNED_OFFSET,
};
#ifdef CONFIG_DEBUG_FS
--
2.46.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/panthor: Add FOP_UNSIGNED_OFFSET to fop_flags
2024-09-20 10:28 [PATCH] drm/panthor: Add FOP_UNSIGNED_OFFSET to fop_flags Liviu Dudau
@ 2024-09-20 12:00 ` Boris Brezillon
2024-09-20 13:16 ` Steven Price
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Boris Brezillon @ 2024-09-20 12:00 UTC (permalink / raw)
To: Liviu Dudau
Cc: Steven Price, David Airlie, Simona Vetter, Christian Brauner,
dri-devel, Al Viro, linux-fsdevel
On Fri, 20 Sep 2024 11:28:02 +0100
Liviu Dudau <liviu.dudau@arm.com> wrote:
> Since 641bb4394f40 ("fs: move FMODE_UNSIGNED_OFFSET to fop_flags")
> the FMODE_UNSIGNED_OFFSET flag has been moved to fop_flags and renamed,
> but the patch failed to make the changes for the panthor driver.
> When user space opens the render node the WARN() added by the patch
> gets triggered.
>
> Fixes: 641bb4394f40 ("fs: move FMODE_UNSIGNED_OFFSET to fop_flags")
> Cc: Christian Brauner <brauner@kernel.org>
> Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
> ---
> drivers/gpu/drm/panthor/panthor_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/panthor/panthor_drv.c b/drivers/gpu/drm/panthor/panthor_drv.c
> index 34182f67136c1..c520f156e2d73 100644
> --- a/drivers/gpu/drm/panthor/panthor_drv.c
> +++ b/drivers/gpu/drm/panthor/panthor_drv.c
> @@ -1383,6 +1383,7 @@ static const struct file_operations panthor_drm_driver_fops = {
> .read = drm_read,
> .llseek = noop_llseek,
> .mmap = panthor_mmap,
> + .fop_flags = FOP_UNSIGNED_OFFSET,
> };
>
> #ifdef CONFIG_DEBUG_FS
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/panthor: Add FOP_UNSIGNED_OFFSET to fop_flags
2024-09-20 10:28 [PATCH] drm/panthor: Add FOP_UNSIGNED_OFFSET to fop_flags Liviu Dudau
2024-09-20 12:00 ` Boris Brezillon
@ 2024-09-20 13:16 ` Steven Price
2024-09-21 7:19 ` Christian Brauner
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Steven Price @ 2024-09-20 13:16 UTC (permalink / raw)
To: Liviu Dudau, Boris Brezillon
Cc: David Airlie, Simona Vetter, Christian Brauner, dri-devel,
Al Viro, linux-fsdevel
On 20/09/2024 11:28, Liviu Dudau wrote:
> Since 641bb4394f40 ("fs: move FMODE_UNSIGNED_OFFSET to fop_flags")
> the FMODE_UNSIGNED_OFFSET flag has been moved to fop_flags and renamed,
> but the patch failed to make the changes for the panthor driver.
> When user space opens the render node the WARN() added by the patch
> gets triggered.
>
> Fixes: 641bb4394f40 ("fs: move FMODE_UNSIGNED_OFFSET to fop_flags")
> Cc: Christian Brauner <brauner@kernel.org>
> Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>
Reviewed-by: Steven Price <steven.price@arm.com>
> ---
> drivers/gpu/drm/panthor/panthor_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/panthor/panthor_drv.c b/drivers/gpu/drm/panthor/panthor_drv.c
> index 34182f67136c1..c520f156e2d73 100644
> --- a/drivers/gpu/drm/panthor/panthor_drv.c
> +++ b/drivers/gpu/drm/panthor/panthor_drv.c
> @@ -1383,6 +1383,7 @@ static const struct file_operations panthor_drm_driver_fops = {
> .read = drm_read,
> .llseek = noop_llseek,
> .mmap = panthor_mmap,
> + .fop_flags = FOP_UNSIGNED_OFFSET,
> };
>
> #ifdef CONFIG_DEBUG_FS
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/panthor: Add FOP_UNSIGNED_OFFSET to fop_flags
2024-09-20 10:28 [PATCH] drm/panthor: Add FOP_UNSIGNED_OFFSET to fop_flags Liviu Dudau
2024-09-20 12:00 ` Boris Brezillon
2024-09-20 13:16 ` Steven Price
@ 2024-09-21 7:19 ` Christian Brauner
2024-10-01 12:44 ` Heiko Stübner
2024-10-01 16:43 ` Boris Brezillon
4 siblings, 0 replies; 6+ messages in thread
From: Christian Brauner @ 2024-09-21 7:19 UTC (permalink / raw)
To: Liviu Dudau
Cc: Boris Brezillon, Steven Price, David Airlie, Simona Vetter,
dri-devel, Al Viro, linux-fsdevel
On Fri, Sep 20, 2024 at 11:28:02AM GMT, Liviu Dudau wrote:
> Since 641bb4394f40 ("fs: move FMODE_UNSIGNED_OFFSET to fop_flags")
> the FMODE_UNSIGNED_OFFSET flag has been moved to fop_flags and renamed,
> but the patch failed to make the changes for the panthor driver.
> When user space opens the render node the WARN() added by the patch
> gets triggered.
>
> Fixes: 641bb4394f40 ("fs: move FMODE_UNSIGNED_OFFSET to fop_flags")
> Cc: Christian Brauner <brauner@kernel.org>
> Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>
> ---
Reviewed-by: Christian Brauner <brauner@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/panthor: Add FOP_UNSIGNED_OFFSET to fop_flags
2024-09-20 10:28 [PATCH] drm/panthor: Add FOP_UNSIGNED_OFFSET to fop_flags Liviu Dudau
` (2 preceding siblings ...)
2024-09-21 7:19 ` Christian Brauner
@ 2024-10-01 12:44 ` Heiko Stübner
2024-10-01 16:43 ` Boris Brezillon
4 siblings, 0 replies; 6+ messages in thread
From: Heiko Stübner @ 2024-10-01 12:44 UTC (permalink / raw)
To: Boris Brezillon, dri-devel
Cc: Steven Price, David Airlie, Simona Vetter, Christian Brauner,
dri-devel, Al Viro, linux-fsdevel, Liviu Dudau
Am Freitag, 20. September 2024, 12:28:02 CEST schrieb Liviu Dudau:
> Since 641bb4394f40 ("fs: move FMODE_UNSIGNED_OFFSET to fop_flags")
> the FMODE_UNSIGNED_OFFSET flag has been moved to fop_flags and renamed,
> but the patch failed to make the changes for the panthor driver.
> When user space opens the render node the WARN() added by the patch
> gets triggered.
>
> Fixes: 641bb4394f40 ("fs: move FMODE_UNSIGNED_OFFSET to fop_flags")
> Cc: Christian Brauner <brauner@kernel.org>
> Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>
On a rk3588-tiger-haikou
Tested-by: Heiko Stuebner <heiko@sntech.de>
with 6.11 panthor was working nicely
with 6.12-rc1 panthor was not recognized by mesa anymore
with this patch applied on top, things are back to a working state.
> ---
> drivers/gpu/drm/panthor/panthor_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/panthor/panthor_drv.c b/drivers/gpu/drm/panthor/panthor_drv.c
> index 34182f67136c1..c520f156e2d73 100644
> --- a/drivers/gpu/drm/panthor/panthor_drv.c
> +++ b/drivers/gpu/drm/panthor/panthor_drv.c
> @@ -1383,6 +1383,7 @@ static const struct file_operations panthor_drm_driver_fops = {
> .read = drm_read,
> .llseek = noop_llseek,
> .mmap = panthor_mmap,
> + .fop_flags = FOP_UNSIGNED_OFFSET,
> };
>
> #ifdef CONFIG_DEBUG_FS
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/panthor: Add FOP_UNSIGNED_OFFSET to fop_flags
2024-09-20 10:28 [PATCH] drm/panthor: Add FOP_UNSIGNED_OFFSET to fop_flags Liviu Dudau
` (3 preceding siblings ...)
2024-10-01 12:44 ` Heiko Stübner
@ 2024-10-01 16:43 ` Boris Brezillon
4 siblings, 0 replies; 6+ messages in thread
From: Boris Brezillon @ 2024-10-01 16:43 UTC (permalink / raw)
To: Liviu Dudau
Cc: Steven Price, David Airlie, Simona Vetter, Christian Brauner,
dri-devel, Al Viro, linux-fsdevel
On Fri, 20 Sep 2024 11:28:02 +0100
Liviu Dudau <liviu.dudau@arm.com> wrote:
> Since 641bb4394f40 ("fs: move FMODE_UNSIGNED_OFFSET to fop_flags")
> the FMODE_UNSIGNED_OFFSET flag has been moved to fop_flags and renamed,
> but the patch failed to make the changes for the panthor driver.
> When user space opens the render node the WARN() added by the patch
> gets triggered.
>
> Fixes: 641bb4394f40 ("fs: move FMODE_UNSIGNED_OFFSET to fop_flags")
> Cc: Christian Brauner <brauner@kernel.org>
> Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>
Queued to drm-misc-fixes.
> ---
> drivers/gpu/drm/panthor/panthor_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/panthor/panthor_drv.c b/drivers/gpu/drm/panthor/panthor_drv.c
> index 34182f67136c1..c520f156e2d73 100644
> --- a/drivers/gpu/drm/panthor/panthor_drv.c
> +++ b/drivers/gpu/drm/panthor/panthor_drv.c
> @@ -1383,6 +1383,7 @@ static const struct file_operations panthor_drm_driver_fops = {
> .read = drm_read,
> .llseek = noop_llseek,
> .mmap = panthor_mmap,
> + .fop_flags = FOP_UNSIGNED_OFFSET,
> };
>
> #ifdef CONFIG_DEBUG_FS
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-10-01 16:43 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-20 10:28 [PATCH] drm/panthor: Add FOP_UNSIGNED_OFFSET to fop_flags Liviu Dudau
2024-09-20 12:00 ` Boris Brezillon
2024-09-20 13:16 ` Steven Price
2024-09-21 7:19 ` Christian Brauner
2024-10-01 12:44 ` Heiko Stübner
2024-10-01 16:43 ` Boris Brezillon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).