From: John Garry <john.g.garry@oracle.com>
To: axboe@kernel.dk, brauner@kernel.org, djwong@kernel.org,
viro@zeniv.linux.org.uk, jack@suse.cz, dchinner@redhat.com,
hch@lst.de, cem@kernel.org
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
hare@suse.de, martin.petersen@oracle.com,
catherine.hoang@oracle.com, mcgrof@kernel.org,
ritesh.list@gmail.com, ojaswin@linux.ibm.com,
John Garry <john.g.garry@oracle.com>
Subject: [PATCH v7 0/8] block atomic writes for xfs
Date: Fri, 4 Oct 2024 09:22:46 +0000 [thread overview]
Message-ID: <20241004092254.3759210-1-john.g.garry@oracle.com> (raw)
This series expands atomic write support to filesystems, specifically
XFS.
Flag FS_XFLAG_ATOMICWRITES is added as an enabling flag for atomic writes.
XFS can be formatted for atomic writes as follows:
mkfs.xfs -i atomicwrites=1 -b size=16384 /dev/sda
Support can be enabled through xfs_io command:
$xfs_io -c "chattr +W" filename
$xfs_io -c "lsattr -v" filename
[atomic-writes] filename
$xfs_io -c statx filename
...
stat.stx_atomic_write_unit_min = 16384
stat.stx_atomic_write_unit_max = 16384
stat.stx_atomic_write_segments_max = 1
...
Dependence on forcealign is gone for the moment. This means that we can
only write a single FS block atomically. Since we can now have FS block
size > PAGE_SIZE for XFS, we can write atomically write 4K+ blocks on
x86.
Using the large FS block size has downsides, so we still want the
forcealign feature.
Baseline is v6.12-rc1
Basic xfsprogs support at:
https://github.com/johnpgarry/xfsprogs-dev/tree/atomic-writes-v7
Patches for this series can be found at:
https://github.com/johnpgarry/linux/tree/atomic-writes-v6.12-fs-v7
Changes since v6:
- Add iomap documentation update (Darrick)
- Drop reflink restriction (Darrick, Christoph)
- Catch XFS buffered IO fallback (Darrick)
- Check IOCB_DIRECT in generic_atomic_write_valid()
- Tweaks to coding style (Darrick)
- Add RB tags from Darrick and Christoph (thanks!)
Changes since v5:
- Drop forcealign dependency
- Can support atomically writing a single FS block
- XFS_DIFLAG2_ATOMICWRITES is inherited from parent directories
- Add RB tags from Darrick (thanks!)
John Garry (8):
block/fs: Pass an iocb to generic_atomic_write_valid()
fs: Export generic_atomic_write_valid()
fs/block: Check for IOCB_DIRECT in generic_atomic_write_valid()
fs: iomap: Atomic write support
xfs: Support FS_XFLAG_ATOMICWRITES
xfs: Support atomic write for statx
xfs: Validate atomic writes
xfs: Support setting FMODE_CAN_ATOMIC_WRITE
.../filesystems/iomap/operations.rst | 11 ++++++
block/fops.c | 22 ++++++-----
fs/iomap/direct-io.c | 38 +++++++++++++++++--
fs/iomap/trace.h | 3 +-
fs/read_write.c | 16 +++++---
fs/xfs/libxfs/xfs_format.h | 11 +++++-
fs/xfs/libxfs/xfs_inode_buf.c | 22 +++++++++++
fs/xfs/libxfs/xfs_inode_util.c | 6 +++
fs/xfs/libxfs/xfs_sb.c | 2 +
fs/xfs/xfs_buf.c | 7 ++++
fs/xfs/xfs_buf.h | 3 ++
fs/xfs/xfs_file.c | 10 +++++
fs/xfs/xfs_inode.h | 22 +++++++++++
fs/xfs/xfs_ioctl.c | 27 +++++++++++++
fs/xfs/xfs_iops.c | 25 ++++++++++++
fs/xfs/xfs_mount.h | 2 +
fs/xfs/xfs_super.c | 4 ++
include/linux/fs.h | 2 +-
include/linux/iomap.h | 1 +
include/uapi/linux/fs.h | 1 +
20 files changed, 211 insertions(+), 24 deletions(-)
--
2.31.1
next reply other threads:[~2024-10-04 9:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-04 9:22 John Garry [this message]
2024-10-04 9:22 ` [PATCH v7 1/8] block/fs: Pass an iocb to generic_atomic_write_valid() John Garry
2024-10-04 9:22 ` [PATCH v7 2/8] fs: Export generic_atomic_write_valid() John Garry
2024-10-04 9:22 ` [PATCH v7 3/8] fs/block: Check for IOCB_DIRECT in generic_atomic_write_valid() John Garry
2024-10-04 12:34 ` Christoph Hellwig
2024-10-04 12:45 ` John Garry
2024-10-04 9:22 ` [PATCH v7 4/8] fs: iomap: Atomic write support John Garry
2024-10-04 9:22 ` [PATCH v7 5/8] xfs: Support FS_XFLAG_ATOMICWRITES John Garry
2024-10-04 12:35 ` Christoph Hellwig
2024-10-04 13:07 ` John Garry
2024-10-07 5:42 ` Christoph Hellwig
2024-10-13 21:06 ` John Garry
2024-10-16 0:52 ` Darrick J. Wong
2024-10-04 9:22 ` [PATCH v7 6/8] xfs: Support atomic write for statx John Garry
2024-10-04 9:22 ` [PATCH v7 7/8] xfs: Validate atomic writes John Garry
2024-10-04 9:22 ` [PATCH v7 8/8] xfs: Support setting FMODE_CAN_ATOMIC_WRITE John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241004092254.3759210-1-john.g.garry@oracle.com \
--to=john.g.garry@oracle.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=catherine.hoang@oracle.com \
--cc=cem@kernel.org \
--cc=dchinner@redhat.com \
--cc=djwong@kernel.org \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mcgrof@kernel.org \
--cc=ojaswin@linux.ibm.com \
--cc=ritesh.list@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).