From: Al Viro <viro@zeniv.linux.org.uk>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
Christian Brauner <brauner@kernel.org>,
linux-fsdevel@vger.kernel.org, linux-unionfs@vger.kernel.org
Subject: Re: [PATCH 3/4] ovl: convert ovl_real_fdget_meta() callers to ovl_real_file_meta()
Date: Fri, 4 Oct 2024 23:23:23 +0100 [thread overview]
Message-ID: <20241004222323.GS4017910@ZenIV> (raw)
In-Reply-To: <20241004102342.179434-4-amir73il@gmail.com>
On Fri, Oct 04, 2024 at 12:23:41PM +0200, Amir Goldstein wrote:
> if (upper_meta) {
> ovl_path_upper(dentry, &realpath);
> if (!realpath.dentry)
> - return 0;
> + return NULL;
> } else {
> /* lazy lookup and verify of lowerdata */
> err = ovl_verify_lowerdata(dentry);
> if (err)
> - return err;
> + return ERR_PTR(err);
Ugh... That kind of calling conventions is generally a bad idea.
> + return realfile;
... especially since it's NULL/ERR_PTR()/pointer to object.
> + realfile = ovl_real_file_meta(file, !datasync);
> + if (IS_ERR_OR_NULL(realfile))
> + return PTR_ERR(realfile);
Please, don't. IS_ERR_OR_NULL is bogus 9 times out of 10 (at least).
And you still have breakage in llseek et.al.
next prev parent reply other threads:[~2024-10-04 22:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-04 10:23 [PATCH 0/4] Stash overlay real upper file in backing_file Amir Goldstein
2024-10-04 10:23 ` [PATCH 1/4] ovl: do not open non-data lower file for fsync Amir Goldstein
2024-10-04 22:16 ` Al Viro
2024-10-04 22:28 ` Al Viro
2024-10-05 1:35 ` Al Viro
2024-10-05 6:30 ` Amir Goldstein
2024-10-05 19:49 ` Al Viro
2024-10-06 8:03 ` Amir Goldstein
2024-10-04 10:23 ` [PATCH 2/4] ovl: stash upper real file in backing_file struct Amir Goldstein
2024-10-04 10:23 ` [PATCH 3/4] ovl: convert ovl_real_fdget_meta() callers to ovl_real_file_meta() Amir Goldstein
2024-10-04 22:23 ` Al Viro [this message]
2024-10-05 12:37 ` Amir Goldstein
2024-10-04 10:23 ` [PATCH 4/4] ovl: convert ovl_real_fdget() callers to ovl_real_file() Amir Goldstein
2024-10-04 22:25 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241004222323.GS4017910@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=amir73il@gmail.com \
--cc=brauner@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).