From: Christian Brauner <brauner@kernel.org>
To: Jonathan Corbet <corbet@lwn.net>
Cc: luca.boccassi@gmail.com, linux-fsdevel@vger.kernel.org,
christian@brauner.io, linux-kernel@vger.kernel.org,
oleg@redhat.com
Subject: Re: [PATCH v9] pidfd: add ioctl to retrieve pid info
Date: Thu, 10 Oct 2024 11:26:04 +0200 [thread overview]
Message-ID: <20241010-nahtlos-erproben-27bf691dcc06@brauner> (raw)
In-Reply-To: <87msjd9j7n.fsf@trenco.lwn.net>
> > + /*
> > + * If userspace and the kernel have the same struct size it can just
> > + * be copied. If userspace provides an older struct, only the bits that
> > + * userspace knows about will be copied. If userspace provides a new
> > + * struct, only the bits that the kernel knows about will be copied and
> > + * the size value will be set to the size the kernel knows about.
> > + */
> > + if (copy_to_user(uinfo, &kinfo, min(usize, sizeof(kinfo))))
> > + return -EFAULT;
>
> Which "size value" are you referring to here; I can't see it.
Luca did just copy my comment from another interface which has a
separate size parameter. This should indeed be fixed.
next prev parent reply other threads:[~2024-10-10 9:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-08 12:18 [PATCH v9] pidfd: add ioctl to retrieve pid info luca.boccassi
2024-10-08 13:06 ` Christian Brauner
2024-10-08 13:10 ` Luca Boccassi
2024-10-09 20:52 ` Aleksa Sarai
2024-10-10 9:38 ` Christian Brauner
2024-10-08 13:23 ` Christian Brauner
2024-10-09 19:20 ` Jonathan Corbet
2024-10-09 20:56 ` Aleksa Sarai
2024-10-09 21:06 ` Aleksa Sarai
2024-10-09 22:05 ` Jonathan Corbet
2024-10-13 5:57 ` Aleksa Sarai
2024-10-10 9:36 ` Christian Brauner
2024-10-10 12:41 ` Jonathan Corbet
2024-10-10 13:16 ` David Laight
2024-10-10 9:26 ` Christian Brauner [this message]
2024-10-09 20:50 ` Aleksa Sarai
2024-10-10 9:46 ` Christian Brauner
2024-10-10 15:55 ` Luca Boccassi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241010-nahtlos-erproben-27bf691dcc06@brauner \
--to=brauner@kernel.org \
--cc=christian@brauner.io \
--cc=corbet@lwn.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.boccassi@gmail.com \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox