From: "André Almeida" <andrealmeid@igalia.com>
To: Gabriel Krisman Bertazi <krisman@kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
Theodore Ts'o <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Hugh Dickins <hughd@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Jonathan Corbet <corbet@lwn.net>,
smcv@collabora.com
Cc: kernel-dev@igalia.com, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-mm@kvack.org, linux-doc@vger.kernel.org,
"Gabriel Krisman Bertazi" <krisman@suse.de>,
"André Almeida" <andrealmeid@igalia.com>
Subject: [PATCH v6 02/10] ext4: Use generic_ci_validate_strict_name helper
Date: Thu, 10 Oct 2024 16:39:37 -0300 [thread overview]
Message-ID: <20241010-tonyk-tmpfs-v6-2-79f0ae02e4c8@igalia.com> (raw)
In-Reply-To: <20241010-tonyk-tmpfs-v6-0-79f0ae02e4c8@igalia.com>
Use the helper function to check the requirements for casefold
directories using strict encoding.
Suggested-by: Gabriel Krisman Bertazi <krisman@suse.de>
Signed-off-by: André Almeida <andrealmeid@igalia.com>
Acked-by: Theodore Ts'o <tytso@mit.edu>
Reviewed-by: Gabriel Krisman Bertazi <krisman@suse.de>
---
Changes from v4:
- Now we can drop the if IS_ENABLED() guard
---
fs/ext4/namei.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
index 790db7eac6c2ad5e1790e363e4ac273162e35013..612ccbeb493b8d901c123221ef6573457193dd16 100644
--- a/fs/ext4/namei.c
+++ b/fs/ext4/namei.c
@@ -2395,11 +2395,8 @@ static int ext4_add_entry(handle_t *handle, struct dentry *dentry,
if (fscrypt_is_nokey_name(dentry))
return -ENOKEY;
-#if IS_ENABLED(CONFIG_UNICODE)
- if (sb_has_strict_encoding(sb) && IS_CASEFOLDED(dir) &&
- utf8_validate(sb->s_encoding, &dentry->d_name))
+ if (!generic_ci_validate_strict_name(dir, &dentry->d_name))
return -EINVAL;
-#endif
retval = ext4_fname_setup_filename(dir, &dentry->d_name, 0, &fname);
if (retval)
--
2.47.0
next prev parent reply other threads:[~2024-10-10 19:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-10 19:39 [PATCH v6 00/10] tmpfs: Add case-insensitive support for tmpfs André Almeida
2024-10-10 19:39 ` [PATCH v6 01/10] libfs: Create the helper function generic_ci_validate_strict_name() André Almeida
2024-10-15 15:59 ` Gabriel Krisman Bertazi
2024-10-16 21:59 ` André Almeida
2024-10-10 19:39 ` André Almeida [this message]
2024-10-10 19:39 ` [PATCH v6 03/10] unicode: Export latest available UTF-8 version number André Almeida
2024-10-15 13:40 ` Gabriel Krisman Bertazi
2024-10-10 19:39 ` [PATCH v6 04/10] unicode: Recreate utf8_parse_version() André Almeida
2024-10-10 19:39 ` [PATCH v6 05/10] libfs: Export generic_ci_ dentry functions André Almeida
2024-10-10 19:39 ` [PATCH v6 06/10] tmpfs: Always set simple_dentry_operations as dentry ops André Almeida
2024-10-10 19:39 ` [PATCH v6 07/10] tmpfs: Add casefold lookup support André Almeida
2024-10-15 18:30 ` Gabriel Krisman Bertazi
2024-10-15 18:35 ` Gabriel Krisman Bertazi
2024-10-10 19:39 ` [PATCH v6 08/10] tmpfs: Add flag FS_CASEFOLD_FL support for tmpfs dirs André Almeida
2024-10-10 19:39 ` [PATCH v6 09/10] tmpfs: Expose filesystem features via sysfs André Almeida
2024-10-10 19:39 ` [PATCH v6 10/10] docs: tmpfs: Add casefold options André Almeida
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241010-tonyk-tmpfs-v6-2-79f0ae02e4c8@igalia.com \
--to=andrealmeid@igalia.com \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=corbet@lwn.net \
--cc=hughd@google.com \
--cc=jack@suse.cz \
--cc=kernel-dev@igalia.com \
--cc=krisman@kernel.org \
--cc=krisman@suse.de \
--cc=linux-doc@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=smcv@collabora.com \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).