From: Christoph Hellwig <hch@lst.de>
To: John Garry <john.g.garry@oracle.com>
Cc: axboe@kernel.dk, brauner@kernel.org, djwong@kernel.org,
viro@zeniv.linux.org.uk, jack@suse.cz, dchinner@redhat.com,
hch@lst.de, cem@kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org, hare@suse.de,
martin.petersen@oracle.com, catherine.hoang@oracle.com,
mcgrof@kernel.org, ritesh.list@gmail.com, ojaswin@linux.ibm.com
Subject: Re: [PATCH v8 6/7] xfs: Validate atomic writes
Date: Tue, 15 Oct 2024 14:16:37 +0200 [thread overview]
Message-ID: <20241015121637.GC32583@lst.de> (raw)
In-Reply-To: <20241015090142.3189518-7-john.g.garry@oracle.com>
On Tue, Oct 15, 2024 at 09:01:41AM +0000, John Garry wrote:
> Validate that an atomic write adheres to length/offset rules. Currently
> we can only write a single FS block.
> + if (iocb->ki_flags & IOCB_ATOMIC) {
> + if (ocount != ip->i_mount->m_sb.sb_blocksize)
> + return -EINVAL;
Maybe throw in a comment here why we are currently limited to atomic
writes of exactly the file system block size and don't allow smaller
values.
Otherwise this looks good to me.
next prev parent reply other threads:[~2024-10-15 12:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-15 9:01 [PATCH v8 0/7] block atomic writes for xfs John Garry
2024-10-15 9:01 ` [PATCH v8 1/7] block/fs: Pass an iocb to generic_atomic_write_valid() John Garry
2024-10-15 9:01 ` [PATCH v8 2/7] fs/block: Check for IOCB_DIRECT in generic_atomic_write_valid() John Garry
2024-10-15 9:01 ` [PATCH v8 3/7] fs: Export generic_atomic_write_valid() John Garry
2024-10-15 9:01 ` [PATCH v8 4/7] fs: iomap: Atomic write support John Garry
2024-10-15 12:12 ` Christoph Hellwig
2024-10-15 12:24 ` John Garry
2024-10-15 9:01 ` [PATCH v8 5/7] xfs: Support atomic write for statx John Garry
2024-10-15 12:15 ` Christoph Hellwig
2024-10-15 12:22 ` John Garry
2024-10-15 12:33 ` Christoph Hellwig
2024-10-15 9:01 ` [PATCH v8 6/7] xfs: Validate atomic writes John Garry
2024-10-15 12:16 ` Christoph Hellwig [this message]
2024-10-15 12:25 ` John Garry
2024-10-15 9:01 ` [PATCH v8 7/7] xfs: Support setting FMODE_CAN_ATOMIC_WRITE John Garry
2024-10-15 12:16 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241015121637.GC32583@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=catherine.hoang@oracle.com \
--cc=cem@kernel.org \
--cc=dchinner@redhat.com \
--cc=djwong@kernel.org \
--cc=hare@suse.de \
--cc=jack@suse.cz \
--cc=john.g.garry@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mcgrof@kernel.org \
--cc=ojaswin@linux.ibm.com \
--cc=ritesh.list@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).