From: Alessandro Zanni <alessandro.zanni87@gmail.com>
To: viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz
Cc: Alessandro Zanni <alessandro.zanni87@gmail.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
skhan@linuxfoundation.org, anupnewsmail@gmail.com,
alessandrozanni.dev@gmail.com,
syzbot+6c55f725d1bdc8c52058@syzkaller.appspotmail.com
Subject: [PATCH] fs: Fix uninitialized value issue in from_kuid
Date: Wed, 16 Oct 2024 14:37:19 +0200 [thread overview]
Message-ID: <20241016123723.171588-1-alessandro.zanni87@gmail.com> (raw)
Fix uninitialized value issue in from_kuid by initializing the newattrs
structure in do_truncate() method.
Fixes: uninit-value in from_kuid reported here
https://syzkaller.appspot.com/bug?extid=6c55f725d1bdc8c52058
Reported-by: syzbot+6c55f725d1bdc8c52058@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=6c55f725d1bdc8c52058
Signed-off-by: Alessandro Zanni <alessandro.zanni87@gmail.com>
---
fs/open.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/open.c b/fs/open.c
index acaeb3e25c88..57c298b1db2c 100644
--- a/fs/open.c
+++ b/fs/open.c
@@ -40,7 +40,7 @@ int do_truncate(struct mnt_idmap *idmap, struct dentry *dentry,
loff_t length, unsigned int time_attrs, struct file *filp)
{
int ret;
- struct iattr newattrs;
+ struct iattr newattrs = {0};
/* Not pretty: "inode->i_size" shouldn't really be signed. But it is. */
if (length < 0)
--
2.43.0
next reply other threads:[~2024-10-16 12:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-16 12:37 Alessandro Zanni [this message]
2024-10-16 13:23 ` [PATCH] fs: Fix uninitialized value issue in from_kuid Jan Kara
2024-10-16 14:52 ` Christian Brauner
2024-10-17 9:22 ` Alessandro Zanni
2024-10-17 9:58 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241016123723.171588-1-alessandro.zanni87@gmail.com \
--to=alessandro.zanni87@gmail.com \
--cc=alessandrozanni.dev@gmail.com \
--cc=anupnewsmail@gmail.com \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=syzbot+6c55f725d1bdc8c52058@syzkaller.appspotmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox