* [PATCH] fuse: zero folio correctly in fuse_notify_store()
@ 2024-10-21 12:59 Hou Tao
2024-10-21 20:59 ` Josef Bacik
2024-10-22 12:00 ` Miklos Szeredi
0 siblings, 2 replies; 3+ messages in thread
From: Hou Tao @ 2024-10-21 12:59 UTC (permalink / raw)
To: linux-fsdevel; +Cc: Miklos Szeredi, Josef Bacik, linux-kernel, houtao1
From: Hou Tao <houtao1@huawei.com>
The third argument of folio_zero_range() should be the length to be
zeroed, not the total length. Fix it by using folio_zero_segment()
instead in fuse_notify_store().
Reported-by: syzbot+65d101735df4bb19d2a3@syzkaller.appspotmail.com
Fixes: 5d9e1455630d ("fuse: convert fuse_notify_store to use folios")
Signed-off-by: Hou Tao <houtao1@huawei.com>
---
fs/fuse/dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/fuse/dev.c b/fs/fuse/dev.c
index 824e329b8fd7..eb89a301c406 100644
--- a/fs/fuse/dev.c
+++ b/fs/fuse/dev.c
@@ -1668,7 +1668,7 @@ static int fuse_notify_store(struct fuse_conn *fc, unsigned int size,
err = fuse_copy_page(cs, &page, offset, this_num, 0);
if (!folio_test_uptodate(folio) && !err && offset == 0 &&
(this_num == folio_size(folio) || file_size == end)) {
- folio_zero_range(folio, this_num, folio_size(folio));
+ folio_zero_segment(folio, this_num, folio_size(folio));
folio_mark_uptodate(folio);
}
folio_unlock(folio);
--
2.29.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] fuse: zero folio correctly in fuse_notify_store()
2024-10-21 12:59 [PATCH] fuse: zero folio correctly in fuse_notify_store() Hou Tao
@ 2024-10-21 20:59 ` Josef Bacik
2024-10-22 12:00 ` Miklos Szeredi
1 sibling, 0 replies; 3+ messages in thread
From: Josef Bacik @ 2024-10-21 20:59 UTC (permalink / raw)
To: Hou Tao; +Cc: linux-fsdevel, Miklos Szeredi, linux-kernel, houtao1
On Mon, Oct 21, 2024 at 08:59:55PM +0800, Hou Tao wrote:
> From: Hou Tao <houtao1@huawei.com>
>
> The third argument of folio_zero_range() should be the length to be
> zeroed, not the total length. Fix it by using folio_zero_segment()
> instead in fuse_notify_store().
>
> Reported-by: syzbot+65d101735df4bb19d2a3@syzkaller.appspotmail.com
> Fixes: 5d9e1455630d ("fuse: convert fuse_notify_store to use folios")
> Signed-off-by: Hou Tao <houtao1@huawei.com>
Oops, that's my bad, thanks for fixing it Hou!
Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Thanks,
Josef
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fuse: zero folio correctly in fuse_notify_store()
2024-10-21 12:59 [PATCH] fuse: zero folio correctly in fuse_notify_store() Hou Tao
2024-10-21 20:59 ` Josef Bacik
@ 2024-10-22 12:00 ` Miklos Szeredi
1 sibling, 0 replies; 3+ messages in thread
From: Miklos Szeredi @ 2024-10-22 12:00 UTC (permalink / raw)
To: Hou Tao; +Cc: linux-fsdevel, Josef Bacik, linux-kernel, houtao1
On Mon, 21 Oct 2024 at 14:47, Hou Tao <houtao@huaweicloud.com> wrote:
>
> From: Hou Tao <houtao1@huawei.com>
>
> The third argument of folio_zero_range() should be the length to be
> zeroed, not the total length. Fix it by using folio_zero_segment()
> instead in fuse_notify_store().
Thanks, folded into the original patch and pushed to #for-next.
Miklos
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-22 12:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-21 12:59 [PATCH] fuse: zero folio correctly in fuse_notify_store() Hou Tao
2024-10-21 20:59 ` Josef Bacik
2024-10-22 12:00 ` Miklos Szeredi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).