From: Zhang Yi <yi.zhang@huaweicloud.com>
To: linux-ext4@vger.kernel.org
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
tytso@mit.edu, adilger.kernel@dilger.ca, jack@suse.cz,
ritesh.list@gmail.com, hch@infradead.org, djwong@kernel.org,
david@fromorbit.com, zokeefe@google.com, yi.zhang@huawei.com,
yi.zhang@huaweicloud.com, chengzhihao1@huawei.com,
yukuai3@huawei.com, yangerkun@huawei.com
Subject: [PATCH 26/27] ext4: change mount options code style
Date: Tue, 22 Oct 2024 19:10:57 +0800 [thread overview]
Message-ID: <20241022111059.2566137-27-yi.zhang@huaweicloud.com> (raw)
In-Reply-To: <20241022111059.2566137-1-yi.zhang@huaweicloud.com>
From: Zhang Yi <yi.zhang@huawei.com>
Just remove the space between the macro name and open parenthesis to
satisfy the checkpatch.pl script and prevent it from complaining when we
add new mount options in the subsequent patch. This will not result in
any logical changes.
Signed-off-by: Zhang Yi <yi.zhang@huawei.com>
---
fs/ext4/super.c | 175 +++++++++++++++++++++++-------------------------
1 file changed, 84 insertions(+), 91 deletions(-)
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 56baadec27e0..89955081c4fe 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -1723,101 +1723,94 @@ static const struct constant_table ext4_param_dax[] = {
* separate for now.
*/
static const struct fs_parameter_spec ext4_param_specs[] = {
- fsparam_flag ("bsddf", Opt_bsd_df),
- fsparam_flag ("minixdf", Opt_minix_df),
- fsparam_flag ("grpid", Opt_grpid),
- fsparam_flag ("bsdgroups", Opt_grpid),
- fsparam_flag ("nogrpid", Opt_nogrpid),
- fsparam_flag ("sysvgroups", Opt_nogrpid),
- fsparam_gid ("resgid", Opt_resgid),
- fsparam_uid ("resuid", Opt_resuid),
- fsparam_u32 ("sb", Opt_sb),
- fsparam_enum ("errors", Opt_errors, ext4_param_errors),
- fsparam_flag ("nouid32", Opt_nouid32),
- fsparam_flag ("debug", Opt_debug),
- fsparam_flag ("oldalloc", Opt_removed),
- fsparam_flag ("orlov", Opt_removed),
- fsparam_flag ("user_xattr", Opt_user_xattr),
- fsparam_flag ("acl", Opt_acl),
- fsparam_flag ("norecovery", Opt_noload),
- fsparam_flag ("noload", Opt_noload),
- fsparam_flag ("bh", Opt_removed),
- fsparam_flag ("nobh", Opt_removed),
- fsparam_u32 ("commit", Opt_commit),
- fsparam_u32 ("min_batch_time", Opt_min_batch_time),
- fsparam_u32 ("max_batch_time", Opt_max_batch_time),
- fsparam_u32 ("journal_dev", Opt_journal_dev),
- fsparam_bdev ("journal_path", Opt_journal_path),
- fsparam_flag ("journal_checksum", Opt_journal_checksum),
- fsparam_flag ("nojournal_checksum", Opt_nojournal_checksum),
- fsparam_flag ("journal_async_commit",Opt_journal_async_commit),
- fsparam_flag ("abort", Opt_abort),
- fsparam_enum ("data", Opt_data, ext4_param_data),
- fsparam_enum ("data_err", Opt_data_err,
+ fsparam_flag("bsddf", Opt_bsd_df),
+ fsparam_flag("minixdf", Opt_minix_df),
+ fsparam_flag("grpid", Opt_grpid),
+ fsparam_flag("bsdgroups", Opt_grpid),
+ fsparam_flag("nogrpid", Opt_nogrpid),
+ fsparam_flag("sysvgroups", Opt_nogrpid),
+ fsparam_gid("resgid", Opt_resgid),
+ fsparam_uid("resuid", Opt_resuid),
+ fsparam_u32("sb", Opt_sb),
+ fsparam_enum("errors", Opt_errors, ext4_param_errors),
+ fsparam_flag("nouid32", Opt_nouid32),
+ fsparam_flag("debug", Opt_debug),
+ fsparam_flag("oldalloc", Opt_removed),
+ fsparam_flag("orlov", Opt_removed),
+ fsparam_flag("user_xattr", Opt_user_xattr),
+ fsparam_flag("acl", Opt_acl),
+ fsparam_flag("norecovery", Opt_noload),
+ fsparam_flag("noload", Opt_noload),
+ fsparam_flag("bh", Opt_removed),
+ fsparam_flag("nobh", Opt_removed),
+ fsparam_u32("commit", Opt_commit),
+ fsparam_u32("min_batch_time", Opt_min_batch_time),
+ fsparam_u32("max_batch_time", Opt_max_batch_time),
+ fsparam_u32("journal_dev", Opt_journal_dev),
+ fsparam_bdev("journal_path", Opt_journal_path),
+ fsparam_flag("journal_checksum", Opt_journal_checksum),
+ fsparam_flag("nojournal_checksum", Opt_nojournal_checksum),
+ fsparam_flag("journal_async_commit", Opt_journal_async_commit),
+ fsparam_flag("abort", Opt_abort),
+ fsparam_enum("data", Opt_data, ext4_param_data),
+ fsparam_enum("data_err", Opt_data_err,
ext4_param_data_err),
- fsparam_string_empty
- ("usrjquota", Opt_usrjquota),
- fsparam_string_empty
- ("grpjquota", Opt_grpjquota),
- fsparam_enum ("jqfmt", Opt_jqfmt, ext4_param_jqfmt),
- fsparam_flag ("grpquota", Opt_grpquota),
- fsparam_flag ("quota", Opt_quota),
- fsparam_flag ("noquota", Opt_noquota),
- fsparam_flag ("usrquota", Opt_usrquota),
- fsparam_flag ("prjquota", Opt_prjquota),
- fsparam_flag ("barrier", Opt_barrier),
- fsparam_u32 ("barrier", Opt_barrier),
- fsparam_flag ("nobarrier", Opt_nobarrier),
- fsparam_flag ("i_version", Opt_removed),
- fsparam_flag ("dax", Opt_dax),
- fsparam_enum ("dax", Opt_dax_type, ext4_param_dax),
- fsparam_u32 ("stripe", Opt_stripe),
- fsparam_flag ("delalloc", Opt_delalloc),
- fsparam_flag ("nodelalloc", Opt_nodelalloc),
- fsparam_flag ("warn_on_error", Opt_warn_on_error),
- fsparam_flag ("nowarn_on_error", Opt_nowarn_on_error),
- fsparam_u32 ("debug_want_extra_isize",
- Opt_debug_want_extra_isize),
- fsparam_flag ("mblk_io_submit", Opt_removed),
- fsparam_flag ("nomblk_io_submit", Opt_removed),
- fsparam_flag ("block_validity", Opt_block_validity),
- fsparam_flag ("noblock_validity", Opt_noblock_validity),
- fsparam_u32 ("inode_readahead_blks",
- Opt_inode_readahead_blks),
- fsparam_u32 ("journal_ioprio", Opt_journal_ioprio),
- fsparam_u32 ("auto_da_alloc", Opt_auto_da_alloc),
- fsparam_flag ("auto_da_alloc", Opt_auto_da_alloc),
- fsparam_flag ("noauto_da_alloc", Opt_noauto_da_alloc),
- fsparam_flag ("dioread_nolock", Opt_dioread_nolock),
- fsparam_flag ("nodioread_nolock", Opt_dioread_lock),
- fsparam_flag ("dioread_lock", Opt_dioread_lock),
- fsparam_flag ("discard", Opt_discard),
- fsparam_flag ("nodiscard", Opt_nodiscard),
- fsparam_u32 ("init_itable", Opt_init_itable),
- fsparam_flag ("init_itable", Opt_init_itable),
- fsparam_flag ("noinit_itable", Opt_noinit_itable),
+ fsparam_string_empty("usrjquota", Opt_usrjquota),
+ fsparam_string_empty("grpjquota", Opt_grpjquota),
+ fsparam_enum("jqfmt", Opt_jqfmt, ext4_param_jqfmt),
+ fsparam_flag("grpquota", Opt_grpquota),
+ fsparam_flag("quota", Opt_quota),
+ fsparam_flag("noquota", Opt_noquota),
+ fsparam_flag("usrquota", Opt_usrquota),
+ fsparam_flag("prjquota", Opt_prjquota),
+ fsparam_flag("barrier", Opt_barrier),
+ fsparam_u32("barrier", Opt_barrier),
+ fsparam_flag("nobarrier", Opt_nobarrier),
+ fsparam_flag("i_version", Opt_removed),
+ fsparam_flag("dax", Opt_dax),
+ fsparam_enum("dax", Opt_dax_type, ext4_param_dax),
+ fsparam_u32("stripe", Opt_stripe),
+ fsparam_flag("delalloc", Opt_delalloc),
+ fsparam_flag("nodelalloc", Opt_nodelalloc),
+ fsparam_flag("warn_on_error", Opt_warn_on_error),
+ fsparam_flag("nowarn_on_error", Opt_nowarn_on_error),
+ fsparam_u32("debug_want_extra_isize", Opt_debug_want_extra_isize),
+ fsparam_flag("mblk_io_submit", Opt_removed),
+ fsparam_flag("nomblk_io_submit", Opt_removed),
+ fsparam_flag("block_validity", Opt_block_validity),
+ fsparam_flag("noblock_validity", Opt_noblock_validity),
+ fsparam_u32("inode_readahead_blks", Opt_inode_readahead_blks),
+ fsparam_u32("journal_ioprio", Opt_journal_ioprio),
+ fsparam_u32("auto_da_alloc", Opt_auto_da_alloc),
+ fsparam_flag("auto_da_alloc", Opt_auto_da_alloc),
+ fsparam_flag("noauto_da_alloc", Opt_noauto_da_alloc),
+ fsparam_flag("dioread_nolock", Opt_dioread_nolock),
+ fsparam_flag("nodioread_nolock", Opt_dioread_lock),
+ fsparam_flag("dioread_lock", Opt_dioread_lock),
+ fsparam_flag("discard", Opt_discard),
+ fsparam_flag("nodiscard", Opt_nodiscard),
+ fsparam_u32("init_itable", Opt_init_itable),
+ fsparam_flag("init_itable", Opt_init_itable),
+ fsparam_flag("noinit_itable", Opt_noinit_itable),
#ifdef CONFIG_EXT4_DEBUG
- fsparam_flag ("fc_debug_force", Opt_fc_debug_force),
- fsparam_u32 ("fc_debug_max_replay", Opt_fc_debug_max_replay),
+ fsparam_flag("fc_debug_force", Opt_fc_debug_force),
+ fsparam_u32("fc_debug_max_replay", Opt_fc_debug_max_replay),
#endif
- fsparam_u32 ("max_dir_size_kb", Opt_max_dir_size_kb),
- fsparam_flag ("test_dummy_encryption",
- Opt_test_dummy_encryption),
- fsparam_string ("test_dummy_encryption",
- Opt_test_dummy_encryption),
- fsparam_flag ("inlinecrypt", Opt_inlinecrypt),
- fsparam_flag ("nombcache", Opt_nombcache),
- fsparam_flag ("no_mbcache", Opt_nombcache), /* for backward compatibility */
- fsparam_flag ("prefetch_block_bitmaps",
- Opt_removed),
- fsparam_flag ("no_prefetch_block_bitmaps",
+ fsparam_u32("max_dir_size_kb", Opt_max_dir_size_kb),
+ fsparam_flag("test_dummy_encryption", Opt_test_dummy_encryption),
+ fsparam_string("test_dummy_encryption", Opt_test_dummy_encryption),
+ fsparam_flag("inlinecrypt", Opt_inlinecrypt),
+ fsparam_flag("nombcache", Opt_nombcache),
+ fsparam_flag("no_mbcache", Opt_nombcache), /* for backward compatibility */
+ fsparam_flag("prefetch_block_bitmaps", Opt_removed),
+ fsparam_flag("no_prefetch_block_bitmaps",
Opt_no_prefetch_block_bitmaps),
- fsparam_s32 ("mb_optimize_scan", Opt_mb_optimize_scan),
- fsparam_string ("check", Opt_removed), /* mount option from ext2/3 */
- fsparam_flag ("nocheck", Opt_removed), /* mount option from ext2/3 */
- fsparam_flag ("reservation", Opt_removed), /* mount option from ext2/3 */
- fsparam_flag ("noreservation", Opt_removed), /* mount option from ext2/3 */
- fsparam_u32 ("journal", Opt_removed), /* mount option from ext2/3 */
+ fsparam_s32("mb_optimize_scan", Opt_mb_optimize_scan),
+ fsparam_string("check", Opt_removed), /* mount option from ext2/3 */
+ fsparam_flag("nocheck", Opt_removed), /* mount option from ext2/3 */
+ fsparam_flag("reservation", Opt_removed), /* mount option from ext2/3 */
+ fsparam_flag("noreservation", Opt_removed), /* mount option from ext2/3 */
+ fsparam_u32("journal", Opt_removed), /* mount option from ext2/3 */
{}
};
--
2.46.1
next prev parent reply other threads:[~2024-10-22 3:13 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-22 11:10 [PATCH 00/27] ext4: use iomap for regular file's buffered I/O path and enable large folio Zhang Yi
2024-10-22 6:59 ` Sedat Dilek
2024-10-22 9:22 ` Zhang Yi
2024-10-23 12:13 ` Sedat Dilek
2024-10-24 7:44 ` Zhang Yi
2024-10-22 11:10 ` [PATCH 01/27] ext4: remove writable userspace mappings before truncating page cache Zhang Yi
2024-12-04 11:13 ` Jan Kara
2024-12-06 7:59 ` Zhang Yi
2024-12-06 15:49 ` Jan Kara
2024-10-22 11:10 ` [PATCH 02/27] ext4: don't explicit update times in ext4_fallocate() Zhang Yi
2024-10-22 11:10 ` [PATCH 03/27] ext4: don't write back data before punch hole in nojournal mode Zhang Yi
2024-11-18 23:15 ` Darrick J. Wong
2024-11-20 2:56 ` Zhang Yi
2024-12-04 11:26 ` Jan Kara
2024-12-04 11:27 ` Jan Kara
2024-10-22 11:10 ` [PATCH 04/27] ext4: refactor ext4_punch_hole() Zhang Yi
2024-11-18 23:27 ` Darrick J. Wong
2024-11-20 3:18 ` Zhang Yi
2024-12-04 11:36 ` Jan Kara
2024-10-22 11:10 ` [PATCH 05/27] ext4: refactor ext4_zero_range() Zhang Yi
2024-12-04 11:52 ` Jan Kara
2024-12-06 8:09 ` Zhang Yi
2024-10-22 11:10 ` [PATCH 06/27] ext4: refactor ext4_collapse_range() Zhang Yi
2024-12-04 11:58 ` Jan Kara
2024-10-22 11:10 ` [PATCH 07/27] ext4: refactor ext4_insert_range() Zhang Yi
2024-12-04 12:02 ` Jan Kara
2024-10-22 11:10 ` [PATCH 08/27] ext4: factor out ext4_do_fallocate() Zhang Yi
2024-10-22 11:10 ` [PATCH 09/27] ext4: move out inode_lock into ext4_fallocate() Zhang Yi
2024-12-04 12:05 ` Jan Kara
2024-12-06 8:13 ` Zhang Yi
2024-12-06 15:51 ` Jan Kara
2024-10-22 11:10 ` [PATCH 10/27] ext4: move out common parts " Zhang Yi
2024-12-04 12:10 ` Jan Kara
2024-10-22 11:10 ` [PATCH 11/27] ext4: use reserved metadata blocks when splitting extent on endio Zhang Yi
2024-12-04 12:16 ` Jan Kara
2024-10-22 11:10 ` [PATCH 12/27] ext4: introduce seq counter for the extent status entry Zhang Yi
2024-12-04 12:42 ` Jan Kara
2024-12-06 8:55 ` Zhang Yi
2024-12-06 16:21 ` Jan Kara
2024-12-09 8:32 ` Zhang Yi
2024-12-10 12:57 ` Jan Kara
2024-12-11 7:59 ` Zhang Yi
2024-12-11 16:00 ` Jan Kara
2024-12-12 2:32 ` Zhang Yi
2024-10-22 11:10 ` [PATCH 13/27] ext4: add a new iomap aops for regular file's buffered IO path Zhang Yi
2024-10-22 11:10 ` [PATCH 14/27] ext4: implement buffered read iomap path Zhang Yi
2024-10-22 11:10 ` [PATCH 15/27] ext4: implement buffered write " Zhang Yi
2024-10-22 11:10 ` [PATCH 16/27] ext4: don't order data for inode with EXT4_STATE_BUFFERED_IOMAP Zhang Yi
2024-10-22 11:10 ` [PATCH 17/27] ext4: implement writeback iomap path Zhang Yi
2024-10-22 11:10 ` [PATCH 18/27] ext4: implement mmap " Zhang Yi
2024-10-22 11:10 ` [PATCH 19/27] ext4: do not always order data when partial zeroing out a block Zhang Yi
2024-10-22 11:10 ` [PATCH 20/27] ext4: do not start handle if unnecessary while " Zhang Yi
2024-10-22 11:10 ` [PATCH 21/27] ext4: implement zero_range iomap path Zhang Yi
2024-10-22 11:10 ` [PATCH 22/27] ext4: disable online defrag when inode using iomap buffered I/O path Zhang Yi
2024-10-22 11:10 ` [PATCH 23/27] ext4: disable inode journal mode when " Zhang Yi
2024-10-22 11:10 ` [PATCH 24/27] ext4: partially enable iomap for the buffered I/O path of regular files Zhang Yi
2024-10-22 11:10 ` [PATCH 25/27] ext4: enable large folio for regular file with iomap buffered I/O path Zhang Yi
2024-10-22 11:10 ` Zhang Yi [this message]
2024-10-22 11:10 ` [PATCH 27/27] ext4: introduce a mount option for " Zhang Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241022111059.2566137-27-yi.zhang@huaweicloud.com \
--to=yi.zhang@huaweicloud.com \
--cc=adilger.kernel@dilger.ca \
--cc=chengzhihao1@huawei.com \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ritesh.list@gmail.com \
--cc=tytso@mit.edu \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
--cc=zokeefe@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).