From: David Sterba <dsterba@suse.cz>
To: "Pankaj Raghav (Samsung)" <kernel@pankajraghav.com>
Cc: "Theodore Ts'o" <tytso@mit.edu>, "Chao Yu" <chao@kernel.org>,
"Jonathan Corbet" <corbet@lwn.net>,
willy@infradead.org, "Josef Bacik" <josef@toxicpanda.com>,
"Johannes Weiner" <hannes@cmpxchg.org>,
"Michal Koutný" <mkoutny@suse.com>,
"Alexander Viro" <viro@zeniv.linux.org.uk>,
"Darrick J . Wong" <djwong@kernel.org>,
"Zefan Li" <lizefan.x@bytedance.com>, "Tejun Heo" <tj@kernel.org>,
akpm@linux-foundation.org,
"Christian Brauner" <brauner@kernel.org>,
"Andreas Dilger" <adilger.kernel@dilger.ca>,
"Jaegeuk Kim" <jaegeuk@kernel.org>, "Jan Kara" <jack@suse.cz>,
"Chris Mason" <clm@fb.com>, "David Sterba" <dsterba@suse.com>,
cgroups@vger.kernel.org, linux-btrfs@vger.kernel.org,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org, mcgrof@kernel.org,
gost.dev@samsung.com, linux-doc@vger.kernel.org,
linux-xfs@vger.kernel.org, "Pankaj Raghav" <p.raghav@samsung.com>
Subject: Re: [PATCH] fs/writeback: convert wbc_account_cgroup_owner to take a folio
Date: Fri, 25 Oct 2024 19:49:59 +0200 [thread overview]
Message-ID: <20241025174959.GH31418@suse.cz> (raw)
In-Reply-To: <20240926140121.203821-1-kernel@pankajraghav.com>
On Thu, Sep 26, 2024 at 04:01:21PM +0200, Pankaj Raghav (Samsung) wrote:
> From: Pankaj Raghav <p.raghav@samsung.com>
>
> Most of the callers of wbc_account_cgroup_owner() are converting a folio
> to page before calling the function. wbc_account_cgroup_owner() is
> converting the page back to a folio to call mem_cgroup_css_from_folio().
>
> Convert wbc_account_cgroup_owner() to take a folio instead of a page,
> and convert all callers to pass a folio directly except f2fs.
>
> Convert the page to folio for all the callers from f2fs as they were the
> only callers calling wbc_account_cgroup_owner() with a page. As f2fs is
> already in the process of converting to folios, these call sites might
> also soon be calling wbc_account_cgroup_owner() with a folio directly in
> the future.
>
> No functional changes. Only compile tested.
>
> Signed-off-by: Pankaj Raghav <p.raghav@samsung.com>
> ---
> fs/btrfs/extent_io.c | 7 +++----
> fs/btrfs/inode.c | 2 +-
If you ever want to continue with the conversion then for the btrfs part
Acked-by: David Sterba <dsterba@suse.com>
next prev parent reply other threads:[~2024-10-25 17:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-26 14:01 [PATCH] fs/writeback: convert wbc_account_cgroup_owner to take a folio Pankaj Raghav (Samsung)
2024-09-26 14:11 ` Matthew Wilcox
2024-09-30 22:58 ` Jaegeuk Kim
2024-10-11 8:56 ` Chao Yu
2024-09-26 16:19 ` Tejun Heo
2024-10-25 17:49 ` David Sterba [this message]
2024-10-28 12:27 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241025174959.GH31418@suse.cz \
--to=dsterba@suse.cz \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=chao@kernel.org \
--cc=clm@fb.com \
--cc=corbet@lwn.net \
--cc=djwong@kernel.org \
--cc=dsterba@suse.com \
--cc=gost.dev@samsung.com \
--cc=hannes@cmpxchg.org \
--cc=jack@suse.cz \
--cc=jaegeuk@kernel.org \
--cc=josef@toxicpanda.com \
--cc=kernel@pankajraghav.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=mcgrof@kernel.org \
--cc=mkoutny@suse.com \
--cc=p.raghav@samsung.com \
--cc=tj@kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).