From: Mohammed Anees <pvmohammedanees2003@gmail.com>
To: jack@suse.cz
Cc: bcrl@kvack.org, brauner@kernel.org, linux-aio@kvack.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
pvmohammedanees2003@gmail.com, viro@zeniv.linux.org.uk,
willy@infradead.org
Subject: Re: [PATCH] fs: aio: Transition from Linked List to Hash Table for Active Request Management in AIO
Date: Wed, 6 Nov 2024 16:27:00 +0530 [thread overview]
Message-ID: <20241106105700.10735-1-pvmohammedanees2003@gmail.com> (raw)
In-Reply-To: <20241031120423.5rq6uykywklkptkv@quack3>
> Well, I'd say that calling io_cancel() isn't really frequent operation. Or
> are you aware of any workload that would be regularly doing that? Hence
> optimizing performance for such operation isn't going to bring much benefit
> to real users. On the other hand the additional complexity of handling
> hashtable for requests in flight (although it isn't big on its own) is
> going to impact everybody using AIO. Hence I agree with Matthew that
> changes like you propose are not a clear win when looking at the bigger
> picture and need good justification.
Makes sense to me, the added complexity may not be worth the
marginal performance gain. Thanks for helping me with this!
next prev parent reply other threads:[~2024-11-06 10:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-20 15:04 [PATCH] fs: aio: Transition from Linked List to Hash Table for Active Request Management in AIO Mohammed Anees
2024-10-21 2:08 ` Matthew Wilcox
2024-10-22 7:03 ` Mohammed Anees
2024-10-31 12:04 ` Jan Kara
2024-10-31 13:02 ` Jeff Moyer
2024-11-06 11:01 ` Mohammed Anees
2024-11-11 16:42 ` Jeff Moyer
2024-11-12 11:33 ` Mohammed Anees
2024-11-06 10:57 ` Mohammed Anees [this message]
2024-10-31 11:51 ` Mohammed Anees
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241106105700.10735-1-pvmohammedanees2003@gmail.com \
--to=pvmohammedanees2003@gmail.com \
--cc=bcrl@kvack.org \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-aio@kvack.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).