From: Joanne Koong <joannelkoong@gmail.com>
To: miklos@szeredi.hu, linux-fsdevel@vger.kernel.org
Cc: josef@toxicpanda.com, bernd.schubert@fastmail.fm,
jefflexu@linux.alibaba.com, willy@infradead.org,
shakeel.butt@linux.dev, kernel-team@meta.com
Subject: [PATCH 11/12] fuse: support large folios for writeback
Date: Fri, 8 Nov 2024 16:12:57 -0800 [thread overview]
Message-ID: <20241109001258.2216604-12-joannelkoong@gmail.com> (raw)
In-Reply-To: <20241109001258.2216604-1-joannelkoong@gmail.com>
Add support for folios larger than one page size for writeback.
Signed-off-by: Joanne Koong <joannelkoong@gmail.com>
---
fs/fuse/file.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/fs/fuse/file.c b/fs/fuse/file.c
index 54e2b58df82f..a542f16d5a69 100644
--- a/fs/fuse/file.c
+++ b/fs/fuse/file.c
@@ -1993,7 +1993,7 @@ static void fuse_writepage_args_page_fill(struct fuse_writepage_args *wpa, struc
folio_get(folio);
ap->folios[folio_index] = folio;
ap->descs[folio_index].offset = 0;
- ap->descs[folio_index].length = PAGE_SIZE;
+ ap->descs[folio_index].length = folio_size(folio);
inc_wb_stat(&inode_to_bdi(inode)->wb, WB_WRITEBACK);
node_stat_add_folio(folio, NR_WRITEBACK);
@@ -2068,6 +2068,7 @@ struct fuse_fill_wb_data {
struct fuse_file *ff;
struct inode *inode;
unsigned int max_folios;
+ unsigned int nr_pages;
};
static bool fuse_pages_realloc(struct fuse_fill_wb_data *data)
@@ -2115,15 +2116,15 @@ static bool fuse_writepage_need_send(struct fuse_conn *fc, struct folio *folio,
WARN_ON(!ap->num_folios);
/* Reached max pages */
- if (ap->num_folios == fc->max_pages)
+ if (data->nr_pages + folio_nr_pages(folio) > fc->max_pages)
return true;
/* Reached max write bytes */
- if ((ap->num_folios + 1) * PAGE_SIZE > fc->max_write)
+ if ((data->nr_pages * PAGE_SIZE) + folio_size(folio) > fc->max_write)
return true;
/* Discontinuity */
- if (ap->folios[ap->num_folios - 1]->index + 1 != folio_index(folio))
+ if (folio_next_index(ap->folios[ap->num_folios - 1]) != folio_index(folio))
return true;
/* Need to grow the pages array? If so, did the expansion fail? */
@@ -2154,6 +2155,7 @@ static int fuse_writepages_fill(struct folio *folio,
if (wpa && fuse_writepage_need_send(fc, folio, ap, data)) {
fuse_writepages_send(data);
data->wpa = NULL;
+ data->nr_pages = 0;
}
if (data->wpa == NULL) {
@@ -2168,6 +2170,7 @@ static int fuse_writepages_fill(struct folio *folio,
folio_start_writeback(folio);
fuse_writepage_args_page_fill(wpa, folio, ap->num_folios);
+ data->nr_pages += folio_nr_pages(folio);
err = 0;
ap->num_folios++;
@@ -2198,6 +2201,7 @@ static int fuse_writepages(struct address_space *mapping,
data.inode = inode;
data.wpa = NULL;
data.ff = NULL;
+ data.nr_pages = 0;
err = write_cache_pages(mapping, wbc, fuse_writepages_fill, &data);
if (data.wpa) {
--
2.43.5
next prev parent reply other threads:[~2024-11-09 0:13 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-09 0:12 [PATCH 00/12] fuse: support large folios Joanne Koong
2024-11-09 0:12 ` [PATCH 01/12] fuse: support copying " Joanne Koong
2024-11-21 22:27 ` Josef Bacik
2024-11-09 0:12 ` [PATCH 02/12] fuse: support large folios for retrieves Joanne Koong
2024-11-21 22:28 ` Josef Bacik
2024-11-09 0:12 ` [PATCH 03/12] fuse: refactor fuse_fill_write_pages() Joanne Koong
2024-11-21 22:28 ` Josef Bacik
2024-11-09 0:12 ` [PATCH 04/12] fuse: support large folios for non-writeback writes Joanne Koong
2024-11-12 17:32 ` Joanne Koong
2024-11-13 18:41 ` Joanne Koong
2024-11-21 22:32 ` Josef Bacik
2024-11-09 0:12 ` [PATCH 05/12] fuse: support large folios for folio reads Joanne Koong
2024-11-22 14:42 ` Josef Bacik
2024-11-09 0:12 ` [PATCH 06/12] fuse: support large folios for symlinks Joanne Koong
2024-11-22 14:43 ` Josef Bacik
2024-11-09 0:12 ` [PATCH 07/12] fuse: support large folios for stores Joanne Koong
2024-11-22 14:45 ` Josef Bacik
2024-11-09 0:12 ` [PATCH 08/12] fuse: support large folios for queued writes Joanne Koong
2024-11-22 14:45 ` Josef Bacik
2024-11-09 0:12 ` [PATCH 09/12] fuse: support large folios for readahead Joanne Koong
2024-11-22 14:47 ` Josef Bacik
2024-11-25 19:23 ` Joanne Koong
2024-11-09 0:12 ` [PATCH 10/12] fuse: support large folios for direct io Joanne Koong
2024-11-22 14:49 ` Josef Bacik
2024-11-09 0:12 ` Joanne Koong [this message]
2024-11-22 14:50 ` [PATCH 11/12] fuse: support large folios for writeback Josef Bacik
2024-11-09 0:12 ` [PATCH 12/12] fuse: enable large folios Joanne Koong
2024-11-22 14:51 ` Josef Bacik
2024-11-09 0:22 ` [PATCH 00/12] fuse: support " Joanne Koong
2024-11-09 0:32 ` Bernd Schubert
2024-11-11 17:44 ` Joanne Koong
2024-11-13 18:58 ` Joanne Koong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241109001258.2216604-12-joannelkoong@gmail.com \
--to=joannelkoong@gmail.com \
--cc=bernd.schubert@fastmail.fm \
--cc=jefflexu@linux.alibaba.com \
--cc=josef@toxicpanda.com \
--cc=kernel-team@meta.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=shakeel.butt@linux.dev \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox